Date: Tue, 4 Aug 2015 07:24:10 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Benjamin Kaduk <bjkfbsd@gmail.com> Cc: Edward Tomasz Napierala <trasz@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r286236 - head/share/man/man9 Message-ID: <20150804042410.GH2072@kib.kiev.ua> In-Reply-To: <20150804041650.GG2072@kib.kiev.ua> References: <201508031630.t73GUmBR092976@repo.freebsd.org> <CAJ5_RoDy=zxpuL8qZQM04EEaRAd_hfjDTyqeYaq6nZmvS5w%2BVg@mail.gmail.com> <20150804041650.GG2072@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 04, 2015 at 07:16:50AM +0300, Konstantin Belousov wrote: > On Mon, Aug 03, 2015 at 01:52:46PM -0400, Benjamin Kaduk wrote: > > On Mon, Aug 3, 2015 at 12:30 PM, Edward Tomasz Napierala <trasz@freebsd.org> > > wrote: > > > > > Author: trasz > > > Date: Mon Aug 3 16:30:47 2015 > > > New Revision: 286236 > > > URL: https://svnweb.freebsd.org/changeset/base/286236 > > > > > > Log: > > > Document vgonel(9). > > > > > > > Er, isn't this a step backwards? > > > > % static void vgonel(struct vnode *); > > > > It is only accidental that anything outside vfs_subr.c can call vgonel(). > Indeed, only kernel modules on some architectures could use a hole in > the kernel linker to reference vgonel(). The kernel itself cannot call > vgonel() outside vfs_subr.c. There is no point in putting vgonel(9) in > the man page. I believe the source of the confusion is the vgonel() definition, which lacks the static qualifier. I propose to remove vgonel(9) reference from the man page and add static to definition. Might be, a review of all functions in vfs_*.c and fixing their missed qualifiers would be useful.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150804042410.GH2072>