Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Feb 2015 17:25:49 +0000
From:      "adrian (Adrian Chadd)" <phabric-noreply@FreeBSD.org>
To:        freebsd-net@freebsd.org
Subject:   [Differential] [Accepted] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).
Message-ID:  <af60ab16f50ee3bd7b41d7886f571b45@localhost.localdomain>
In-Reply-To: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org>
References:  <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
adrian accepted this revision.
adrian added a comment.
This revision is now accepted and ready to land.

My only request here is that you commit the mechanical changes separate to the migration fixes. That way it's very clear what's supposed to be fixing the bug and what's improving the readability/consistency of the code.

Other than that, great work on nailing this down.

REVISION DETAIL
  https://reviews.freebsd.org/D1711

To: rrs, gnn, rwatson, sbruno, lstewart, hselasky, imp, adrian
Cc: jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?af60ab16f50ee3bd7b41d7886f571b45>