Date: Tue, 19 Oct 2004 23:51:30 +0200 From: Andre Oppermann <andre@freebsd.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c Message-ID: <41758C62.E27112C0@freebsd.org> References: <200410192135.i9JLZgmv002301@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson wrote: > > rwatson 2004-10-19 21:35:42 UTC > > FreeBSD src repository > > Modified files: > sys/netinet ip_divert.c > Log: > Annotate a newly introduced race present due to the unloading of > protocols: it is possible for sockets to be created and attached > to the divert protocol between the test for sockets present and > successful unload of the registration handler. We will need to > explore more mature APIs for unregistering the protocol and then > draining consumers, or an atomic test-and-unregister mechanism. Thanks. I'll commit a little extended locking of that section in a few minutes. Is it possible for someone else to spin on the lock while we are holding it? If yes, it would be impossible to destroy the lock on the next line. The same problem is then resident in ipfw unloading as well. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41758C62.E27112C0>