Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Apr 1996 13:43:06 +0200 (MET DST)
From:      Andreas Klemm <andreas@knobel.gun.de>
To:        asami@cs.berkeley.edu (Satoshi Asami), ports@freebsd.org, current@freebsd.org
Subject:   make clean should remove README.html in ports collection
Message-ID:  <199604051143.NAA21078@knobel.gun.de>

next in thread | raw e-mail | index | archive | help
Hi !

I have automated for me the process of updating and checking out
the sources of the main source tree and the ports collection.
After creating the README.html files - which are not part of the
source repository - I always get the following lines, when I
get informed via e-mail, what has been changed ...

? ports/lang/icon/README.html
? ports/lang/itcl/README.html
? ports/lang/logo/README.html
? ports/lang/mit-scheme/README.html
? ports/lang/modula-3/README.html
? ports/lang/p2c/README.html
? ports/lang/pTk/README.html
? ports/lang/pbasic/README.html
? ports/lang/perl5/README.html
C ports/lang/pgcc/Makefile
? ports/lang/pgcc/akl.diff
? ports/lang/pgcc/README.html
? ports/lang/python/README.html
? ports/lang/scheme48/README.html
? ports/lang/schemetoc/README.html

The many notes, that README.html isn't part of the source repository,
is a bit disturbing. Simply filtering out all lines with sed would be
possible, but perhaps there is another solution ...

What do you think ?

a) check the README.html files in into the source repository ?
b) create an additional tag into mk/bsd.ports*.mk to remove only
   those files on demand, so one can get rid of them separately
c) remove them generally in the 'make clean' target...

I deceided to 'hack' the make clean target, to remove those README's...

I'd prefer to add the README.html's into the source repository and
to add an additional target to remove them on demand.

What I have here is solution c) ... another good working
possibility ;-)

Index: bsd.port.mk
===================================================================
RCS file: /cvs/src/share/mk/bsd.port.mk,v
retrieving revision 1.199
diff -u -r1.199 bsd.port.mk
--- bsd.port.mk 1996/04/01 11:12:58     1.199
+++ bsd.port.mk 1996/04/05 11:20:20
@@ -899,6 +899,7 @@
 .else
        @${RM} -rf ${WRKDIR}
 .endif
+       @${RM} -f README.html
 .endif
 
 # Prints out a list of files to fetch (useful to do a batch fetch)
Index: bsd.port.subdir.mk
===================================================================
RCS file: /cvs/src/share/mk/bsd.port.subdir.mk,v
retrieving revision 1.13
diff -u -r1.13 bsd.port.subdir.mk
--- bsd.port.subdir.mk  1996/04/01 11:13:00     1.13
+++ bsd.port.subdir.mk  1996/04/05 11:28:13
@@ -72,6 +72,7 @@
 
 .if !target(clean)
 clean: _SUBDIRUSE
+       @rm -f README.html
 .endif
 
 .if !target(depend)


-- 
andreas@knobel.gun.de         /\/\___      Wiechers & Partner Datentechnik GmbH
   Andreas Klemm          ___/\/\/         $$  Support Unix - aklemm@wup.de  $$
pgp p-key  http://www-swiss.ai.mit.edu/~bal/pks-toplev.html  >>> powered by <<<
ftp://sunsite.unc.edu/pub/Linux/system/Printing/aps-491.tgz  >>>    FreeBSD <<<



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199604051143.NAA21078>