Date: Fri, 25 Mar 2011 18:23:10 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/libexec/rtld-elf rtld.c Message-ID: <201103251823.p2PINXTZ054935@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
avg 2011-03-25 18:23:10 UTC
FreeBSD src repository
Modified files:
libexec/rtld-elf rtld.c
Log:
SVN rev 220004 on 2011-03-25 18:23:10Z by avg
rtld: eliminate double call to close(2) that may occur in load_object
The second close(2) call resulted in heisenbugs in some multi-threaded
applications where e.g. dlopen(3) call in one thread could close a file
descriptor for a file having been opened in other thread concurrently.
My litmus test for this issue was an openoffice.org build.
Reviewed by: jhb
MFC after: 2 weeks
Revision Changes Path
1.174 +2 -5 src/libexec/rtld-elf/rtld.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103251823.p2PINXTZ054935>