Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jul 2004 23:16:21 +0200
From:      "Poul-Henning Kamp" <phk@phk.freebsd.dk>
To:        Marius Strobl <marius@alchemy.franken.de>
Cc:        cvs-src@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/watchdogd watchdogd.c 
Message-ID:  <47640.1091049381@critter.freebsd.dk>
In-Reply-To: Your message of "Wed, 28 Jul 2004 23:37:51 %2B0200." <20040728233751.A31182@newtrinity.zeist.de> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20040728233751.A31182@newtrinity.zeist.de>, Marius Strobl writes:
>On Fri, Jul 23, 2004 at 03:24:58PM +0000, Brian Feldman wrote:
>> green       2004-07-23 15:24:58 UTC
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     usr.sbin/watchdogd   watchdogd.c 
>>   Log:
>>   Now that mlockall(2) is unbroken, use it to keep watchdogd(8) permanently
>>   out of swap.
>>   
>
>This broke watchdogd(8) on at least alpha and sparc64:
>omega# watchdogd
>watchdogd: mlockall: Resource temporarily unavailable
>
>Like I told you before, every call of mlockall(MCL_CURRENT) returns -1
>and sets errno to EAGAIN on these platforms.

Worse, if it had worked it would have prevented watchdogd from
detecting swap disk related issues.

The only kind of special treatment you should give a watchdog daemons
is negative benefits so that it will be more sensitive to trouble.

Please back this out.


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47640.1091049381>