Date: Wed, 14 Nov 2001 13:30:02 -0800 (PST) From: Tony Maher <tonymaher@optushome.com.au> To: freebsd-ports@FreeBSD.org Subject: Re: ports/31208: Fix bugs in net/generic-nqs. Now it really works! Message-ID: <200111142130.fAELU2u69791@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/31208; it has been noted by GNATS.
From: Tony Maher <tonymaher@optushome.com.au>
To: freebsd-gnats-submit@FreeBSD.org, sa264@cam.ac.uk
Cc: tom@FreeBSD.org
Subject: Re: ports/31208: Fix bugs in net/generic-nqs. Now it really works!
Date: Thu, 15 Nov 2001 08:26:26 +1100
[MAINTAINER RESPONSE]
Sorry for the delay at looking at this.
> files/patch-ab is empty so should be removed.
Yes it should.
> files/patch-ah fixes the bug which prevented NQS from sending emails.
Looks ok to me.
> files/patch-ai fixes the bug which caused removal of jobs from a pipe
> queue when all the inbound-load-balanced queues that follow it are
> busy.
Looks correct to me but I do not have a network to test with at the moment.
interconn is required on BSD systems (see patch-aa).
Actually I'd suggest that this patch-ai be modified to do error checking
as in patch-aa
if (interconn () < 0) {
fprintf (stderr, "%s(FATAL): Unable to get ", Nqsmgr_prefix);
fprintf (stderr, "a pipe to the local daemon.\n");
exit (16);
}
> files/nqs.sh really kills the nqsdaemon.
Looks good to me - it gets all the daemons and -KILL _is_ required.
Please commit.
thanks
--
Tony Maher
Systems Engineer email: tonym@biolateral.com.au
BioLateral Pty Ltd. phone: +61 2 9980 8595
PO Box A51 Enfield South fax: +61 2 9642 5011
NSW Australia 2133
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111142130.fAELU2u69791>