Date: Fri, 30 May 2014 11:31:12 +0200 From: Antoine Brodin <antoine@FreeBSD.org> To: John Marino <marino@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r355806 - head/x11-themes/clearlooks-themes-extras Message-ID: <CAALwa8k-48YpPwA2qiMw%2BfwmdE4QJ=JHBkv=tSv2XUpWAPAFKA@mail.gmail.com> In-Reply-To: <201405300923.s4U9N2SU054380@svn.freebsd.org> References: <201405300923.s4U9N2SU054380@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 30, 2014 at 11:23 AM, John Marino <marino@freebsd.org> wrote: > Author: marino > Date: Fri May 30 09:23:02 2014 > New Revision: 355806 > URL: http://svnweb.freebsd.org/changeset/ports/355806 > QAT: https://qat.redports.org/buildarchive/r355806/ > > Log: > x11-themes/clearlooks-themes-extras: Stage support+ > > In addition to supporting stage, the unnecessarily custom extraction > target was replaced with NO_WRKSUBDIR. > > Modified: > head/x11-themes/clearlooks-themes-extras/Makefile Hi, This looks wrong: - creates a directory outside of stagedir during install - use of NO_WRKSUBDIR + cd ${WRKSRC} && ${FIND} . ... is usually harmfull Cheers, Antoine > > Modified: head/x11-themes/clearlooks-themes-extras/Makefile > ============================================================================== > --- head/x11-themes/clearlooks-themes-extras/Makefile Fri May 30 09:21:44 2014 (r355805) > +++ head/x11-themes/clearlooks-themes-extras/Makefile Fri May 30 09:23:02 2014 (r355806) > @@ -12,11 +12,11 @@ MAINTAINER= ports@FreeBSD.org > COMMENT= Extras colour schemes for Clearlooks engine theme > > NO_BUILD= yes > +NO_WRKSUBDIR= yes > USE_GNOME= gtk20 > > THEME_DIR= ${PREFIX}/share/themes > > -NO_STAGE= yes > .include <bsd.port.pre.mk> > > .if exists(${LOCALBASE}/libdata/pkgconfig/gtk-engines-2.pc) || defined(WITH_GTKENGINE) > @@ -25,14 +25,10 @@ RUN_DEPENDS= ${LOCALBASE}/libdata/pkgcon > RUN_DEPENDS= ${LOCALBASE}/lib/gtk-2.0/${GTK2_VERSION}/engines/libclearlooks.so:${PORTSDIR}/x11-themes/clearlooks > .endif > > -do-extract: > - @${MKDIR} ${WRKSRC} > - @(cd ${WRKSRC} && ${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} \ > - ${DISTDIR}/${DISTFILES} ${EXTRACT_AFTER_ARGS}) > - > do-install: > @${MKDIR} ${THEME_DIR} > @cd ${WRKSRC} && ${FIND} . -print | \ > - ${CPIO} -pdm -L -R ${SHAREOWN}:${SHAREGRP} ${THEME_DIR} > + ${CPIO} -pdm -L -R ${SHAREOWN}:${SHAREGRP} \ > + ${STAGEDIR}${THEME_DIR} > > .include <bsd.port.post.mk> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8k-48YpPwA2qiMw%2BfwmdE4QJ=JHBkv=tSv2XUpWAPAFKA>