Date: Fri, 30 May 2014 14:13:21 +0300 From: Alex Kozlov <ak@FreeBSD.org> To: John Marino <marino@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r355815 - head/textproc/no-hunspell Message-ID: <20140530111321.GA31400@ravenloft.kiev.ua> In-Reply-To: <201405301014.s4UAEfYE077850@svn.freebsd.org> References: <201405301014.s4UAEfYE077850@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 30, 2014 at 10:14:41AM +0000, John Marino wrote: > Author: marino > Date: Fri May 30 10:14:40 2014 > New Revision: 355815 > URL: http://svnweb.freebsd.org/changeset/ports/355815 > QAT: https://qat.redports.org/buildarchive/r355815/ > > Log: > textproc/no-hunspell: use explicit UNZIP_CMD (requires infozip) > > The tool needed for extract is zip. However UNZIP_CMD explicitly refers > to zipinfo, and UNZIP_NATIVE_CMD isn't available on DragonFly. To future- > proof the port, convert EXTRACT_CMD and EXTRACT_BEFORE_ARGS to UNZIP_CMD > and the default zip extraction args. The (small) price is a new > dependency on infozip. Covered by general infrastructure blanket. Please revert this. Previous version worked on DragonFly without infozip dependency. Also, if automatic EXTRACT_CMD selection will be implemented, I'll fix all edge cases, so there is no need to change ports to make them 'future-proof'. p.s. Afaik, UNZIP_CMD doesn't refers to zipinfo. > Modified: > head/textproc/no-hunspell/Makefile > > Modified: head/textproc/no-hunspell/Makefile > ============================================================================== > --- head/textproc/no-hunspell/Makefile Fri May 30 10:13:39 2014 (r355814) > +++ head/textproc/no-hunspell/Makefile Fri May 30 10:14:40 2014 (r355815) > @@ -12,7 +12,7 @@ DIST_SUBDIR= ${PORTNAME} > MAINTAINER= office@FreeBSD.org > COMMENT= Norwegian (Nynorsk and Bokmaal) hunspell dictionaries > > -USES= zip > +USES= zip:infozip > NO_BUILD= yes > > PLIST_FILES= %%DATADIR%%/nb_NO.aff \ > @@ -23,8 +23,8 @@ PLIST_DIRSTRY= %%DATADIR%% > > post-extract: > @${MKDIR} ${WRKSRC} > - @${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${WRKDIR}/nb_NO.zip -d ${WRKSRC} > - @${EXTRACT_CMD} ${EXTRACT_BEFORE_ARGS} ${WRKDIR}/nn_NO.zip -d ${WRKSRC} > + @${UNZIP_CMD} -qo ${WRKDIR}/nb_NO.zip -d ${WRKSRC} > + @${UNZIP_CMD} -qo ${WRKDIR}/nn_NO.zip -d ${WRKSRC} > > do-install: > ${MKDIR} ${STAGEDIR}${DATADIR}/ -- Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140530111321.GA31400>