Date: Tue, 18 Nov 2014 22:29:52 +0300 From: Chagin Dmitry <dchagin@freebsd.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r274635 - head/sys/dev/pci Message-ID: <20141118192952.GA945@dchagin.static.corbina.net> In-Reply-To: <CAJ-VmokdN8=AS4LMsvHNEi3bhX0U=CQG-=_od3Pcf10yTpMkkA@mail.gmail.com> References: <201411172025.sAHKPLMl055666@svn.freebsd.org> <2245618.H2SPKlpWdS@ralph.baldwin.cx> <20141118064626.GA956@dchagin.static.corbina.net> <CAJ-VmokdN8=AS4LMsvHNEi3bhX0U=CQG-=_od3Pcf10yTpMkkA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--/9DWx/yDrRhgMJTb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 18, 2014 at 07:47:46AM -0800, Adrian Chadd wrote: > Hi, >=20 > Want to post a bootverbose suspend/resume pass with -HEAD without this > patch in it, then with this patch in it? >=20 it seems that at resume path METHOD set_powerstate() is not invoked. fro pr= oper pciX. ie, no "Transition from D3 to D0" prints. i'm trying to understand the reas= on=20 > We should likely revert this commit (for correctness) and then dig > deeper into what's going on. >=20 sure. >=20 >=20 > -adrian >=20 >=20 > On 17 November 2014 22:46, Chagin Dmitry <dchagin@freebsd.org> wrote: > > On Mon, Nov 17, 2014 at 05:45:23PM -0500, John Baldwin wrote: > >> On Monday, November 17, 2014 08:25:21 PM Dmitry Chagin wrote: > >> > Author: dchagin > >> > Date: Mon Nov 17 20:25:21 2014 > >> > New Revision: 274635 > >> > URL: https://svnweb.freebsd.org/changeset/base/274635 > >> > > >> > Log: > >> > Use the correct device as the power_for_sleep() method > >> > always pass request up to parent bridge. > >> > > >> > Reviewed by: jhb > >> > MFC after: 1 week > >> > xMFC: r274386,r274397 > >> > >> Hmm, I had misread this diff as being another instance of what Adrian = had > >> found. I think this is actually not correct. The parent of a pci dev= ice > >> ('dev' here) is a pciX device. pciX devices do not implement the > >> PCIB_POWER_FOR_SLEEP method from pcib_if.m, so this probably just broke > >> Adrian's Asus laptop as now it will always use D3 again and ignore _Sx= D. > > ugh.. i understood, let me see more closely > >> > >> You said that this change fixed your laptop, yes? Did it work before = Adrian's > >> change in r274386 and break afterwards? > > yes > > > > -- > > Have fun! > > chd --=20 Have fun! chd --/9DWx/yDrRhgMJTb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlRrnjAACgkQ0t2Tb3OO/O1mHQCfTTUzutDz+3FA24Em5+Mu+gKZ wmYAnA9K/hfW+uMP+I3/XaqrLi3La0BG =kboy -----END PGP SIGNATURE----- --/9DWx/yDrRhgMJTb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141118192952.GA945>