Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 03 Dec 2009 09:57:30 -0600
From:      Nathan Whitehorn <nwhitehorn@freebsd.org>
To:        Alexander Motin <mav@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 171334 for review
Message-ID:  <4B17DFEA.1020704@freebsd.org>
In-Reply-To: <200912031546.nB3Fksxc047234@repoman.freebsd.org>
References:  <200912031546.nB3Fksxc047234@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Motin wrote:
> http://p4web.freebsd.org/chv.cgi?CH=171334
>
> Change 171334 by mav@mav_mavbook on 2009/12/03 15:46:47
>
> 	Migrate powerpc ATA controllers to the new world order.
> 	Submitted by:	nwitehorn@
>
> Affected files ...
>
> .. //depot/projects/scottl-camlock/src/sys/powerpc/powermac/ata_dbdma.c#2 edit
> .. //depot/projects/scottl-camlock/src/sys/powerpc/powermac/ata_kauai.c#7 edit
> .. //depot/projects/scottl-camlock/src/sys/powerpc/powermac/ata_macio.c#6 edit
> .. //depot/projects/scottl-camlock/src/sys/powerpc/psim/ata_iobus.c#6 edit
>
> Differences ...
>
> ==== //depot/projects/scottl-camlock/src/sys/powerpc/powermac/ata_dbdma.c#2 (text+ko) ====
>
> @@ -230,7 +229,7 @@
>  		return EIO;
>  	}
>  
> -	request->dma = &ch->dma.slot[atadev->unit];
> +	request->dma = &ch->dma.slot[0];
>  
>  	if ((error = bus_dmamap_load(request->dma->data_tag, 
>  	    request->dma->data_map, request->data, request->bytecount,
>   
I made an error in this part of the patch -- it should be request->unit, 
not 0, here. Thanks for your work!
-Nathan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B17DFEA.1020704>