Date: Mon, 08 Dec 2008 12:28:03 -0500 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: arch@FreeBSD.org Subject: Re: RFC: New VOP to translate vnode to its component name Message-ID: <1228757283.69132.14.camel@shumai.marcuscom.com> In-Reply-To: <86tz9fynmf.fsf@ds4.des.no> References: <1228667168.69753.16.camel@shumai.marcuscom.com> <86tz9fynmf.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-n0RvummTzj+AenzdrfD+ Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Mon, 2008-12-08 at 11:20 +0100, Dag-Erling Sm=F8rgrav wrote: > Joe Marcus Clarke <marcus@FreeBSD.org> writes: > > Here is a patch to HEAD, along with a man page, for VOP_CNP. VOP_CNP > > translates a vnode to its component name. It is currently called from > > vn_fullpath1() to traverse a vnode hierarchy when cache lookups for > > those vnodes fail. I have currently implemented VOP_CNP for devfs and > > pseudofs. Kostik has thoroughly reviewed the devfs implementation. I > > only recently did the pseudofs implementation at his request. >=20 > I would prefer pidbuf[PFS_NAMLEN] to pidbuf[11], and you can avoid two > strlen()s by storing the return value from snprintf(). Also, defining > pidbuf at the start of the block instead of the start of the function is > a style(9) violation. Other than that, the pseudofs part of the patch > has my approval. Thanks for the feedback. This was a section of the pfs code I especially wanted some comments on. I'll take care of your suggestions. Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-n0RvummTzj+AenzdrfD+ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkk9WSAACgkQb2iPiv4Uz4dFbgCeMyEWYjM2gPN3FtMNaSWI8VuR Uo4AniLI5atkL0eWolKlxsnx40/S58G+ =4Ndi -----END PGP SIGNATURE----- --=-n0RvummTzj+AenzdrfD+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1228757283.69132.14.camel>