Date: Mon, 27 Oct 2008 17:24:55 +0200 From: Diomidis Spinellis <dds@aueb.gr> To: Andriy Gapon <avg@icyb.net.ua>, Harti Brandt <harti@FreeBSD.ORG> Cc: current@FreeBSD.ORG Subject: Re: cp(1) and mmap Message-ID: <4905DD47.7040107@aueb.gr> In-Reply-To: <483F1559.2020600@aueb.gr> References: <20080528110003.Q24259@beagle.kn.op.dlr.de> <483D5DF8.4020504@icyb.net.ua> <483F1559.2020600@aueb.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
Diomidis Spinellis wrote: > Andriy Gapon wrote: >> on 28/05/2008 12:02 Harti Brandt said the following: >>> Hi all, >>> >>> it looks like there is no fallback in cp(1) when mmaping the source file >>> fails. I'm mounting SMB shares via smbnetfs (which in turn uses fuse) >>> and it seems not to support mmaping files. Shouldn't cp just fallback to >>> a normal read()/write() loop in this case? >> >> I would think that it should. >> This topic was brought up several times, but no resolution so far. >> I think that I've even seen patches. >> > > I've not seen the patches, but the fix is trivial (see the attached > patch). If there are no objections, I can commit it. Fix committed in 184342. Sorry for the long delay. - dds
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4905DD47.7040107>