Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Jun 2010 08:07:54 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r208814 - head/sys/dev/ahci
Message-ID:  <201006050807.o5587sQ7059614@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Sat Jun  5 08:07:54 2010
New Revision: 208814
URL: http://svn.freebsd.org/changeset/base/208814

Log:
  Plug memory leak to silent Coverity. Error is still not really handled.
  
  Found with:   Coverity Prevent(tm)
  CID:          4130

Modified:
  head/sys/dev/ahci/ahci.c

Modified: head/sys/dev/ahci/ahci.c
==============================================================================
--- head/sys/dev/ahci/ahci.c	Sat Jun  5 08:02:19 2010	(r208813)
+++ head/sys/dev/ahci/ahci.c	Sat Jun  5 08:07:54 2010	(r208814)
@@ -2047,6 +2047,7 @@ ahci_issue_read_log(device_t dev)
 	ataio = &ccb->ataio;
 	ataio->data_ptr = malloc(512, M_AHCI, M_NOWAIT);
 	if (ataio->data_ptr == NULL) {
+		xpt_free_ccb(ccb);
 		device_printf(dev, "Unable allocate memory for READ LOG command");
 		return; /* XXX */
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006050807.o5587sQ7059614>