Date: Thu, 9 Jul 2015 10:21:16 +0100 From: David Chisnall <theraven@FreeBSD.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: Konstantin Belousov <kostikbel@gmail.com>, Peter Jeremy <peter@rulingia.com>, Doug Rabson <dfr@rabson.org>, Jamie Landeg-Jones <jamie@dyslexicfish.net>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: gettimeofday((void *)-1, NULL) implicates core dump on recent FreeBSD 11-CURRENT Message-ID: <F43A112B-A190-45F4-9796-B6274B97FAF7@FreeBSD.org> In-Reply-To: <CAGHfRMBMhraJfMZFnw4A5_NgNdXWsCKmDfw%2B1MiAbqs0VY%2B32Q@mail.gmail.com> References: <CAPQ4ffuTcN_ytcH7GPY0s6OqWK9qo6MGaVZhOB%2B0ojWfd=fNCg@mail.gmail.com> <201507072241.t67MfsX5085860@hergotha.csail.mit.edu> <94BCDA65-5B86-4329-A312-4CB16E847B69@dons.net.au> <CAPQ4ffuuaiWGUthEhux2VrK6ZyHDT=0xd9z8k8f11N=6shdUng@mail.gmail.com> <201507081616.t68GGcY9047713@dyslexicfish.net> <CACA0VUhFjBhPMTr=QD71jEvis9CMSrnpyu=xFiXu27nLeozGJA@mail.gmail.com> <0C541CE5-C322-4273-AE0B-1ACAEACCA096@gmail.com> <20150708222717.GE98562@server.rulingia.com> <20150709084145.GI2080@kib.kiev.ua> <CAGHfRMBMhraJfMZFnw4A5_NgNdXWsCKmDfw%2B1MiAbqs0VY%2B32Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 Jul 2015, at 10:17, NGie Cooper <yaneurabeya@gmail.com> wrote: >=20 > I agree that this is less applicable for FreeBSD than NetBSD. Please > keep in mind that contrib/netbsd-tests came from NetBSD, not FreeBSD. > Peter Holm and I tried our best to vet out the issues with the test > suite before integrating it in, but there might be issues due to > implementation discrepancies between FreeBSD and NetBSD. The high-level question is whether these are conformance tests (in which = case they should be checking for specified behaviour) or regression = tests (in which case they should be checking for known implementation = details, but should explicitly document what those are). When the gettimeofday implementation changed, it would have been nice to = get two results: - No conformance tests failed, change is still a valid implementation of = POSIX gettimeofday() - One regression test failed. This test is assuming that gettimeofday() = is a system call and so should be marked as an expected failure. Unfortunately, the test suite currently conflates the two. David
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F43A112B-A190-45F4-9796-B6274B97FAF7>