Date: Mon, 3 Feb 2003 13:20:08 -0800 (PST) From: Cyrille Lefevre <cyrille.lefevre@laposte.net> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/46363: patch for building misc/sh-utils on 5.X and 4.7-STABLE Message-ID: <200302032120.h13LK8Pa085210@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/46363; it has been noted by GNATS. From: Cyrille Lefevre <cyrille.lefevre@laposte.net> To: Christian Weisgerber <naddy@freebsd.org> Cc: Sebastien Gioria <gioria@freebsd.org>, freebsd gnats <freebsd-gnats-submit@freebsd.org> Subject: Re: ports/46363: patch for building misc/sh-utils on 5.X and 4.7-STABLE Date: Mon, 3 Feb 2003 22:11:01 +0100 On Sat, Jan 04, 2003 at 02:09:52AM +0100, Christian Weisgerber wrote: > Cyrille Lefevre: > > > > misc/sh-utils doesn't build on 5.0 because src/test.c defines a > > > function eaccess() that collides with 5.0's eaccess(2). > > > > see http://www.freebsd.org/cgi/query-pr.cgi?pr=46363 > > I'm not certain that the private eaccess() function has the same > semantics as the system call. Specifically, the comment regarding > the x bit handling looks different from the eaccess.2 man page. you are right, in doubt, I propose the following patch : Makefile PORTREVISION bumped files/patch-src::test.c new file --- /dev/null Mon Feb 3 22:00:06 2003 +++ files/patch-src::test.c Mon Feb 3 21:58:57 2003 @@ -0,0 +1,10 @@ +--- src/test.c.orig Mon Feb 3 21:58:52 2003 ++++ src/test.c Mon Feb 3 21:58:16 2003 +@@ -153,6 +153,7 @@ + return (stat (path, finfo)); + } + ++#define eaccess test_access + /* Do the same thing access(2) does, but use the effective uid and gid, + and don't make the mistake of telling root that any file is executable. + But this loses when the containing filesystem is mounted e.g. read-only. */ Index: Makefile =================================================================== RCS file: /home/ncvs/ports/misc/sh-utils/Makefile,v retrieving revision 1.13 diff -u -r1.13 Makefile --- Makefile 1 Aug 2002 16:22:28 -0000 1.13 +++ Makefile 3 Feb 2003 21:01:57 -0000 @@ -7,7 +7,7 @@ PORTNAME= sh-utils PORTVERSION= 2.0 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= misc MASTER_SITES= ${MASTER_SITE_GNU} MASTER_SITE_SUBDIR= sh-utils Cyrille. -- Cyrille Lefevre mailto:cyrille.lefevre@laposte.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200302032120.h13LK8Pa085210>