Date: Tue, 5 Jan 2010 00:50:42 -0500 From: Alexander Kabaev <kabaev@gmail.com> To: David Xu <davidxu@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201547 - head/lib/libc/gen Message-ID: <20100105005042.7fd9db85@kan.dnsalias.net> In-Reply-To: <4B42D07A.5000803@freebsd.org> References: <201001050339.o053dV1j075171@svn.freebsd.org> <20100104233946.6d8bfa37@kan.dnsalias.net> <4B42D07A.5000803@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/r1jJl/6LmJiltlx8/HPQCSW Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 05 Jan 2010 13:39:06 +0800 David Xu <davidxu@freebsd.org> wrote: > Alexander Kabaev wrote: > > Hi, > >=20 > > some quick questions: > >=20 > > FB10_COMPAT_PRIVATE is not used anywhere, why did it get committed? > > That aside, use of SYM_DEFAULT is pretty much always wrong. > >=20 > Yes, this needs to be cleaned. >=20 > > Also, does libthr really need to export sem_ symbols in 1.2 > > namespace? I do not think so, but there might be reasons I am > > missing, could you shed some light here? > >=20 >=20 > If libthr.so does not have 1.2 semaphore, a program linked against=20 > libthr may use 1.0 version at linking time, doesn't this cause > trouble? anyway, I am not symbol versioning expert, welcome to fix it. >=20 No, that won't happen. Compat (single '@') symbols are only resolvable at runtime, bit at link time, so ld won't see any sem_ symbols in libthr and by necessity will pick ones from libc. --=20 Alexander Kabaev --Sig_/r1jJl/6LmJiltlx8/HPQCSW Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iD8DBQFLQtOmQ6z1jMm+XZYRAtNPAKCcgaPECN3d4E0hz0if5Vh1/RX6ggCfbL+f 3KL2Sr7OKHUWX5F2SMc0IoY= =P1Cy -----END PGP SIGNATURE----- --Sig_/r1jJl/6LmJiltlx8/HPQCSW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100105005042.7fd9db85>