Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 May 2010 08:46:55 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        Kostik Belousov <kostikbel@gmail.com>, Ed Schouten <ed@80386.nl>, Roman Divacky <rdivacky@freebsd.org>, freebsd-arch@freebsd.org
Subject:   Re: Request for review: build infrastructure for Clang
Message-ID:  <4BF407EF.7010508@FreeBSD.org>
In-Reply-To: <201005190904.22248.jhb@freebsd.org>
References:  <20100514152408.GN56080@hoeg.nl> <4BF30230.8020001@FreeBSD.org> <20100519071630.GA77151@freebsd.org> <201005190904.22248.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 5/19/2010 6:04 AM, John Baldwin wrote:
> On Wednesday 19 May 2010 3:16:30 am Roman Divacky wrote:
>> On Tue, May 18, 2010 at 02:10:08PM -0700, Doug Barton wrote:
>>> On 5/18/2010 12:35 AM, Roman Divacky wrote:
>>>> two now (clang and tblgen) with one more coming soon (llvm-mc/as)
>>>
>>> With just two binaries I'd suggest usr.bin/clang and usr.bin/tblgen.
>>
>> the tblgen is used only for building clang/llvm stuff so I don't
>> think it deserves it's own directory. maybe we should not even
>> install in during installworld
>
> Given that we nest for gcc, I think it is fine to nest for clang.

That makes it sound like it's some sort of privilege that we don't want 
clang to feel bad about if it doesn't get. :)

In any case, if tblgen isn't even used other than as a build tool then I 
agree, "nesting" is reasonable, and I think Roman is right that it 
shouldn't be installed either. Not that the BIND bmake is authoritative 
in any way, but it has a parallel here in that I have to build the BIND 
libs in order to build the binaries but unless the user twiddles the 
knob I don't install the libs.

... which leads to hopefully my last suggestion, if there is _any_ 
chance that it would be useful to have tblgen installed then providing a 
knob to do so (defaulting to off of course) is cheap, and will prevent 
you having to rework the code later when someone requests it (and 
believe me, someone will). :)


hth,

Doug

-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BF407EF.7010508>