Date: Fri, 29 Jul 2011 20:31:52 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Andrew Boyer <aboyer@averesystems.com> Cc: freebsd-scsi@freebsd.org, John Baldwin <jhb@FreeBSD.org> Subject: Re: Buglet in r222899 (mfiutil show drives) Message-ID: <9DA3510F-0678-46C0-A1A3-0F612EE8D7C3@FreeBSD.org> In-Reply-To: <8B3E8C5D-C8BF-4AB7-AA1E-54086C6DC818@averesystems.com> References: <8B3E8C5D-C8BF-4AB7-AA1E-54086C6DC818@averesystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 29, 2011, at 7:24 PM, Andrew Boyer wrote:
> The error variable is returned uninitialized if no error occurs. I =
noticed because 'mfiutil -de show drives' started returning 1 for no =
apparent reason when I synced up to stable/8.
>=20
> I looked through the rest of mfiutil and didn't see any more cases =
like this one.
>=20
John found that a couple of days ago; it's likely it's in the re@ queue =
for committing and fixing or has been fixed in head already.
> -Andrew
>=20
> Index: usr.sbin/mfiutil/mfi_show.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- usr.sbin/mfiutil/mfi_show.c (revision 224494)
> +++ usr.sbin/mfiutil/mfi_show.c (working copy)
> @@ -470,7 +470,7 @@
> struct mfi_pd_list *list;
> struct mfi_pd_info info;
> u_int i, len, state_len;
> - int error, fd;
> + int error =3D 0, fd;
>=20
> if (ac !=3D 1) {
> warnx("show drives: extra arguments");
>=20
> --------------------------------------------------
> Andrew Boyer aboyer@averesystems.com
>=20
>=20
>=20
>=20
--=20
Bjoern A. Zeeb You have to have visions!
Stop bit received. Insert coin for new address family.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9DA3510F-0678-46C0-A1A3-0F612EE8D7C3>