Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Jun 2010 08:44:40 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r208820 - head/sys/dev/ata/chipsets
Message-ID:  <201006050844.o558iepw068051@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Sat Jun  5 08:44:40 2010
New Revision: 208820
URL: http://svn.freebsd.org/changeset/base/208820

Log:
  Fix use after free on error.
  
  Found with:   Coverity Prevent(tm)
  CID:          4722

Modified:
  head/sys/dev/ata/chipsets/ata-acerlabs.c

Modified: head/sys/dev/ata/chipsets/ata-acerlabs.c
==============================================================================
--- head/sys/dev/ata/chipsets/ata-acerlabs.c	Sat Jun  5 08:36:37 2010	(r208819)
+++ head/sys/dev/ata/chipsets/ata-acerlabs.c	Sat Jun  5 08:44:40 2010	(r208820)
@@ -133,6 +133,7 @@ ata_ali_chipinit(device_t dev)
 				bus_release_resource(dev, SYS_RES_IOPORT,
 				    PCIR_BAR(i), res->bars[i]);
 			free(res, M_TEMP);
+			return ENXIO;
 		}
 	}
 	ctlr->chipset_data = res;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006050844.o558iepw068051>