Date: Sun, 25 Feb 2001 11:54:37 -0500 From: Garrett Rooney <rooneg@electricjellyfish.net> To: Maxim Sobolev <sobomax@freebsd.org> Cc: ports@freebsd.org, jhk@freebsd.org, gad@freebsd.org, reg@freebsd.org Subject: Re: [patch] which package functionality for pkg_info Message-ID: <20010225115436.I39060@electricjellyfish.net> In-Reply-To: <200102251057.f1PAvor63002@vic.sabbo.net>; from sobomax@freebsd.org on Sun, Feb 25, 2001 at 12:57:08PM %2B0200 References: <20010225001624.A41801@electricjellyfish.net> <200102251057.f1PAvor63002@vic.sabbo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 25, 2001 at 12:57:08PM +0200, Maxim Sobolev wrote: > I believe that some time ago Jeremy Leas <reg@FreeBSD.org> did something > similar, but for some reasons his patch had not been merged into base > system yet (see http://people.freebsd.org/~reg/). Therefore I would like > to see your patches merged with his before they will be committed. upon review of Jeremy's patch, it seems to address all that i wanted to see and more! his changes seem far more invasive (although they seem like a good thing in the long run, as they provide a lot of interesting functionality), and it seems that there is a fair amount of work that needs to be done (from what is on the web page anyway). if there is interest in seeing some subset of these features before his entire rework is complete, i would be willing to rip out the portions of his code that cover this functionality and add whatever changes people felt were necessary. one things i notice is that his 'add_which_entry()' function makes use of realpath(3), which as jordan pointed out, is a bad thing if parts of the filesystem are symlinked off somewhere. if people would be interested in seeing these parts of jeremy's work split out and made into a separate patch, that could be committed sooner, and jeremy has no problem with that, i would be more than willing to do the leg work to make it possible. it's very nice to see that other people have been as annoyed at the deficiencies in our package tools as i have, and even nicer to see that they were able to come up with much nicer ways to do things than i did ;-) -- garrett rooney Unix was not designed to stop you from rooneg@electricjellyfish.net doing stupid things, because that would http://electricjellyfish.net/ stop you from doing clever things. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010225115436.I39060>