Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Dec 2014 11:24:08 +0000 (UTC)
From:      "Andrey V. Elsukov" <ae@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r275822 - stable/10/sys/netipsec
Message-ID:  <201412161124.sBGBO8fJ024824@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ae
Date: Tue Dec 16 11:24:07 2014
New Revision: 275822
URL: https://svnweb.freebsd.org/changeset/base/275822

Log:
  MFC r275575:
    key_getspacq() returns holding the spacq_lock. Unlock it in all cases.
  
  Sponsored by:	Yandex LLC

Modified:
  stable/10/sys/netipsec/key.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/netipsec/key.c
==============================================================================
--- stable/10/sys/netipsec/key.c	Tue Dec 16 09:49:07 2014	(r275821)
+++ stable/10/sys/netipsec/key.c	Tue Dec 16 11:24:07 2014	(r275822)
@@ -2336,7 +2336,8 @@ key_spdacquire(sp)
 		} else {
 			/* increment counter and do nothing. */
 			newspacq->count++;
-			return 0;
+			SPACQ_UNLOCK();
+			return (0);
 		}
 		SPACQ_UNLOCK();
 	} else {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201412161124.sBGBO8fJ024824>