Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Feb 2009 09:58:49 +0300
From:      "Yuriy Tsibizov" <Yuriy.Tsibizov@gfk.com>
To:        "Robert Watson" <rwatson@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Cc:        Kip Macy <kmacy@freebsd.org>
Subject:   RE: svn commit: r188962 - head/sys/netinet
Message-ID:  <BA0C4C2EEBEBFD448415F22CE73EEC0C13C95C@ex-be-1.hhp.local>
In-Reply-To: <200902232257.n1NMvtgt042002@svn.freebsd.org>
References:  <200902232257.n1NMvtgt042002@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: rwatson
> Date: Mon Feb 23 22:57:55 2009
> New Revision: 188962
> URL: http://svn.freebsd.org/changeset/base/188962
>=20
> Log:
>   In in_rtqkill(), assert the radix head lock, and pass RTF_RNH_LOCKED
>   to in_rtrequest(); the radix head lock is already acquired before
>   rnh_walktree is called in in_rtqtimo_one().  This avoids a recursive
>   acquisition that is no longer permitted in 8.x due to use=20
> of an rwlock
>   for the radix head lock.
>  =20
>   Reported by:	dikshie <dikshie at gmail.com>
>   MFC after:	3 days
Will it fix this panic (Kip promised to fix it, if he had time):

_rw_wlock_hard: recursing but non-recursive rw radix node head @
/usr/src/sys/net/route.c:831

exclusive rw radix node head (radix node head) r =3D 0 (0xc57fd280) =
locked
@ /usr/src/sys/netinet/in_rmx.c:275

db:0:kdb.enter.panic>  bt
Tracing pid 12 tid 100009 td 0xc5592480
kdb_enter(c0becf98,c0becf98,c0bec9a4,c52bcaa4,1,...) at kdb_enter+0x3a
panic(c0bec9a4,c0b7d2d5,c0bf30f2,c0bfc97f,33f,...) at panic+0x136
_rw_wlock_hard(c57fd280,c5592480,c0bfc97f,33f,0,...) at
_rw_wlock_hard+0x66
_rw_wlock(c57fd280,c0bfc97f,33f,c08436d8,c5cecb40,...) at _rw_wlock+0xae
rtrequest1_fib(2,c52bcb4c,0,0,0,...) at rtrequest1_fib+0x95
rtrequest_fib(2,c597d780,c597d790,0,40017,...) at rtrequest_fib+0x5e
in_rtrequest(2,c597d780,c597d790,0,40017,...) at in_rtrequest+0x3b
in_rtqkill(c5b25000,c52bcc1c,c57fd200,c57fd280,0,...) at in_rtqkill+0x7f
rn_walktree(c57fd200,c0929c80,c52bcc1c,c57fd300,0,...) at
rn_walktree+0x65
in_rtqtimo(c57fd200,0,c0bee33f,176,c0d40094,...) at in_rtqtimo+0xb0
softclock(c0d40060,c52bccc8,c082c134,c0d44400,c5590db8,...) at
softclock+0x24a
intr_event_execute_handlers(c554b7ec,c5590d80,c0be928c,4dd,c5590df0,...)
at intr_event_execute_handlers+0x125
ithread_loop(c554a0f0,c52bcd38,c0be9005,32d,c554b7ec,...) at
ithread_loop+0x9f
fork_exit(c081ae30,c554a0f0,c52bcd38) at fork_exit+0xb8
fork_trampoline() at fork_trampoline+0x8

Yuriy.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BA0C4C2EEBEBFD448415F22CE73EEC0C13C95C>