Date: Mon, 3 May 2010 21:31:33 +0200 From: Marius Strobl <marius@alchemy.franken.de> To: Scott Long <scottl@samsco.org> Cc: Alexander Motin <mav@freebsd.org>, FreeBSD-Current <freebsd-current@freebsd.org>, freebsd-geom@freebsd.org Subject: Re: Switchover to CAM ATA? Message-ID: <20100503193133.GL56967@alchemy.franken.de> In-Reply-To: <5446E60D-0EE8-403E-A409-071ECE2EC534@samsco.org> References: <4BD06BD9.6030401@FreeBSD.org> <20100424193034.GA9853@alchemy.franken.de> <4BD58C35.2010305@FreeBSD.org> <5446E60D-0EE8-403E-A409-071ECE2EC534@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 26, 2010 at 09:18:07AM -0600, Scott Long wrote: > On Apr 26, 2010, at 6:51 AM, Alexander Motin wrote: > > Marius Strobl wrote: > >> As noted earlier, pc98 and sparc64 need ada(4)/CAM ATA to perform > >> geometry translation as done by ad_firmware_geom_adjust() for ad(4), > >> which the following patch hooks up to both: > >> http://people.freebsd.org/~marius/ata_disk_firmware_geom_adjust.diff > >> You preferred to implement such functionality via XPT_CALC_GEOMETRY > >> though (I'm still not convinced that it makes sense to put this > >> functionality into every ATA SIM the same way it is done for SCSI > >> rather than letting ada(4) handle it the same way for all SIMs > >> however). Have you looked into implementing XPT_CALC_GEOMETRY for > >> ATA CAM or is it okay to commit the above patch? > > > > Sorry, I have forgotten about this. > > > > I don't have better idea. For ATA translation seems indeed more > > platform- then controller-specific. May be I would just preferred to see > > this hack to be done inside XPT_CALC_GEOMETRY handler, as it is done now > > for PC98 SCSI. But looking that whole this topic is quite crappy and > > hopefully going to die sometimes, I won't argue much against committing > > this as-is for now. > > Put this into XPT_CALC_GEOMETRY. There's no point in perpetuating the mistakes of the ata driver. > Give me a day or two to think of a reasonable way to do it right. > Did you get further with this approach? Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100503193133.GL56967>