Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Jun 2012 17:11:13 +0000
From:      Max Brazhnikov <makc@freebsd.org>
To:        Grzegorz Blach <magik@roorback.net>
Cc:        freebsd-ports-bugs@freebsd.org
Subject:   Re: ports/167405: EFL updated to 1.1.0 and E17 updated to svn 65643
Message-ID:  <201206071711.14444.makc@freebsd.org>
In-Reply-To: <201205242020.q4OKK4Na025057@freefall.freebsd.org>
References:  <201205242020.q4OKK4Na025057@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 24 May 2012 20:20:04 GMTThu, 24 May 2012 22:17:59 +0200, Grzegorz Blach wrote:
>  Now http://files.roorback.net/e17/diffs/all.diff
>  also have included all *.shar archives.

Thanks! Sorry for delay, I've been busy for awhile.

The patch looks fine. However I'd like to replace http://files.roorback.net/e17/2011-12-02/base/ in MASTER_SITES with ${MASTER_SITES_E17} and define MASTER_SITES_E17 in Mk/bsd.efl.mk.
This way you don't need to change each Makefile next upgrade.

Second, in a new port benchmarks/expedite you pass --enable-* to configure args, but there are no corresponding --disable-*. Shouldn't they be added?

I've tested ports on my tinderbox, several ports failed with similar errors. I've uploaded build logs to http://people.freebsd.org/~makc/tb/e17/

Cheers,
Max



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206071711.14444.makc>