Date: Thu, 25 Apr 2002 21:00:35 -0400 From: Mike Barcroft <mike@FreeBSD.ORG> To: Garance A Drosihn <drosih@rpi.edu> Cc: arch@FreeBSD.ORG, "M. Warner Losh" <imp@village.org>, freebsd-standards@FreeBSD.ORG Subject: Re: diff & patch problem with 'No newline' Message-ID: <20020425210035.A43192@espresso.q9media.com> In-Reply-To: <p05111715b8ee4710a108@[128.113.24.47]>; from drosih@rpi.edu on Thu, Apr 25, 2002 at 08:11:40PM -0400 References: <200202091752.g19HqFP11551@green.bikeshed.org> <p05101421b88b76a6aa12@[128.113.24.47]> <20020210040158.A26957@chiark.greenend.org.uk> <p05101422b88ba26bec5e@[128.113.24.47]> <p05111715b8ee4710a108@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
Garance A Drosihn <drosih@rpi.edu> writes: > And now, a mere two months later, I finally looked into it. > Changing 'diff' is trivial, but the main issue is changing > 'patch' to match. > > I found out that NetBSD had made changes to 'patch' so it > does understand these lines. I copy&pasted those changes > into our version, and it looks like it works right. The > patch is pretty straightforward, and I would like to get > it into our patch in for 4.6-release (along with the minor > change to 'diff'). Any objections? Yes. I still maintain that files without a trailing new line are not "text files", and should therefore be treated as binary files. Even if we did consider these to be "text files", no standards that I'm aware of define the behavior for this situation, so a non-standard patch utility would be required to interpret these extensions. This would make our generated diffs unportable in the same way as some of the other vendors you mentioned as having this feature. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020425210035.A43192>