Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Jul 2014 12:30:23 -0400
From:      John Baldwin <john@baldwin.cx>
To:        freebsd-acpi@freebsd.org
Cc:        Anthony Jenkins <Anthony.B.Jenkins@att.net>, Daniele Mazzotti <kappei84@gmail.com>, Ian Smith <smithi@nimnet.asn.au>
Subject:   Re: ACPI support - Freebsd 10 on Sony Vaio VPCCA3C5E
Message-ID:  <13718226.Ho98q5fHLH@pippin.baldwin.cx>
In-Reply-To: <20140717011710.W50382@sola.nimnet.asn.au>
References:  <CAC=ypSVopgcL82FpqJosmgFeRkeeevP0RG-GrAEZD2YQyi%2BPrg@mail.gmail.com> <53C67D70.6060603@att.net> <20140717011710.W50382@sola.nimnet.asn.au>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 17 July 2014 03:16:10 Ian Smith wrote:
> On Wed, 16 Jul 2014 09:26:08 -0400, Anthony Jenkins wrote:
>  > On 07/16/2014 01:32, Daniele Mazzotti wrote:
>  >> Hi guys, thanks again for the support, but I am leaving for a
>  >> businesses trip and I will be forced to put this debug thing on hold
>  >> for a while. I will be back on track next week.
>  > 
>  > Bah... really wanted to figure out the patch problem.  I suspect the
>  > file picked up some corruption somewhere between the email and your
>  > FreeBSD filesystem.  Your OS version has the same revision of that
>  > source file as mine, so it should apply cleanly.  If you feel like
>  > tinkering with it in your free time, I've posted the patch here:
>  > http://pastebin.com/P0B44u0c
>  > 
>  > Good luck,
>  > Anthony
> 
> Either by show raw and save, or by download, the patch has ^M lineends.
> 
> Interesting, but I can't see atrtc.c being the right sort of place for
> this, seems way out of scope.  Couldn't you include its headers and use
> functions rtcin() and writertc() from elsewhere in kernel, perhaps a
> module living in the same hierarchy as acpi_ibm, acpi_asus and such,
> that one could build and kldload if useful on a certain machine/s?

I disagree, I think this is exactly the right place to do it.  The CMOS access
on x86 boxes is going to be via the RTC, and the folks from Intel even 
indicated that the proper place to put the CMOS region handler is in the 
driver that claims the RTC PNP ID.  The only pending question I was aware of 
is that Anthony had asked the Intel guys a question about a return code, but 
that barring that the patch was ready to go into the tree (and should probably 
go in soon so it can make 10.1).

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13718226.Ho98q5fHLH>