Date: Tue, 16 Dec 2008 19:00:09 GMT From: Evan Powers <evan.powers+bsdbug@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/129689: devel/git installs zero-length git-p4import Message-ID: <200812161900.mBGJ09JB066533@www.freebsd.org> Resent-Message-ID: <200812161910.mBGJA1wb030419@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 129689
>Category: ports
>Synopsis: devel/git installs zero-length git-p4import
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Dec 16 19:10:00 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Evan Powers
>Release: 8.0-CURRENT
>Organization:
>Environment:
>Description:
See the Makefile for devel/git (v 1.6.0.5):
> # grep -C2 git-p4import.py Makefile
> .ifdef (WITH_P4)
> @${REINPLACE_CMD} -e'1s|#!/usr/bin/python|#!${PYTHON_CMD}|' \
> ${WRKSRC}/contrib/p4import/git-p4import.py > \
> ${WRKSRC}/contrib/p4import/git-p4import
> .endif
Note that that's RE*IN*PLACE_CMD, so git-p4import.py gets patched in-place without printing anything to stdout; thus, git-p4import is zero length.
>How-To-Repeat:
cd /usr/ports/devel/git
make install
>Fix:
.ifdef (WITH_P4)
@${CP} ${WRKSRC}/contrib/p4import/git-p4import.py \
${WRKSRC}/contrib/p4import/git-p4import
@${REINPLACE_CMD} -e'1s|#!/usr/bin/python|#!${PYTHON_CMD}|' \
${WRKSRC}/contrib/p4import/git-p4import
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812161900.mBGJ09JB066533>