Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Jan 1997 20:39:11 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, joerg@freefall.freebsd.org
Subject:   Re: cvs commit:  src/sys/conf files src/sys/dev/pdq pdq.c pdq_ifsubr.c src/sys/net if_fddisubr.c src/sys/pci if_fpa.c if_pdq.c pdq.c pdq_os.h pdqreg.h src/sys/i386/conf files.i386 src/sys/i386/eisa if_fea.c src/sys/netinet if_fddi.h
Message-ID:  <199701180939.UAA13800@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>joerg       97/01/17 15:54:45
>
>  Modified:    sys/conf  files
>               sys/dev/pdq  pdq.c pdq_ifsubr.c
>               sys/i386/conf  files.i386
>               sys/i386/eisa  if_fea.c
>               sys/net   if_fddisubr.c
>               sys/netinet  if_fddi.h
>               sys/pci   if_fpa.c
>  Removed:     sys/pci   if_pdq.c pdq.c pdq_os.h pdqreg.h
>  Log:
>  This mega-merge brings Matt Thomas' 960801 FDDI driver (almost) up
>  to -current.

Please keep "files" and files.i386 sorted.

Please don't move files to /sys/dev, losing history.

Please don't put anything into /sys/dev until it is organized properly.
The current organization, with one driver per subdirectory and and
1-4 files per subdirectory could hardly be worse.

LINT no longer compiles:
...
../../net/if_fddisubr.c: In function `fddi_output':
../../net/if_fddisubr.c:225: structure has no member named `if_addrlist'
../../dev/pdq/pdq_ifsubr.c: In function `pdq_os_addr_fill':
../../dev/pdq/pdq_ifsubr.c:253: storage size of `step' isn't known
../../dev/pdq/pdq_ifsubr.c:256: warning: implicit declaration of function `ETHER_FIRST_MULTI'
../../dev/pdq/pdq_ifsubr.c:258: dereferencing pointer to incomplete type
../../dev/pdq/pdq_ifsubr.c:259: dereferencing pointer to incomplete type
../../dev/pdq/pdq_ifsubr.c:260: dereferencing pointer to incomplete type
../../dev/pdq/pdq_ifsubr.c:261: warning: implicit declaration of function `ETHER_NEXT_MULTI'
../../dev/pdq/pdq_ifsubr.c: In function `pdq_ifioctl':
../../dev/pdq/pdq_ifsubr.c:339: warning: implicit declaration of function `ether_addmulti'
../../dev/pdq/pdq_ifsubr.c:341: warning: implicit declaration of function `ether_delmulti'
...
../../i386/eisa/if_fea.c: In function `pdq_eisa_probe':
../../i386/eisa/if_fea.c:206: warning: passing arg 2 of `eisa_match_dev' from incompatible pointer type

>  One final patch will follow in a separate commit.  This is so that
>  everything up to here can be dragged into 2.2, if we decide so.

This patch only reduced the bug in if_fddisubr.c.   if_addrlist was previously
dereferenced.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701180939.UAA13800>