Date: Wed, 16 Mar 2005 13:19:53 -0800 (PST) From: Frank Mayhar <frank@exit.com> To: Maxime Henrion <mux@freebsd.org> Cc: Kris Kennaway <kris@freebsd.org> Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c Message-ID: <200503162119.j2GLJsoN012601@realtime.exit.com> In-Reply-To: <20050316184056.GP31320@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxime Henrion wrote: > Kris Kennaway wrote: > > On Wed, Mar 16, 2005 at 04:39:04PM +0000, Maxime Henrion wrote: > > > mux 2005-03-16 16:39:04 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/fxp if_fxp.c > > > Log: > > > Unload and destroy the TX DMA maps before destroying the DMA tag > > > they're attached to, not after. > > > > > > Spotted by: Coverity via sam > > Is this likely to have caused panics at runtime? A few people > > (including me) have seen dma-related or use-after-free panics from > > fxp. > This won't fix any use-after-free panics at runtime, since the faulty > code is in fxp_release() which will only get called from fxp_attach() in > error scenarios and from fxp_detach(). On the other hand, this may well fix some problems I was seeing with fxp wedging during boot or panicing during kldload. (I haven't seen any use-after-free panics, though, and I use fxp pretty heavily.) -- Frank Mayhar frank@exit.com http://www.exit.com/ Exit Consulting http://www.gpsclock.com/ http://www.exit.com/blog/frank/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503162119.j2GLJsoN012601>