Date: Sun, 15 May 2011 16:32:30 -0700 From: Matthew Fleming <mdf356@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: Ed Schouten <ed@80386.nl>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-user@freebsd.org" <svn-src-user@freebsd.org> Subject: Re: svn commit: r221962 - in user/avg/xcpu/sys: kern sys Message-ID: <BANLkTinHC=TP9cbhev9y33ngJrW18XBFeQ@mail.gmail.com> In-Reply-To: <4DD00522.2010309@FreeBSD.org> References: <201105151432.p4FEWtTw042031@svn.freebsd.org> <20110515150759.GI111@hoeg.nl> <4DCFFAFF.7020403@FreeBSD.org> <BANLkTi=m8aN2k4P%2BbZ8jakj%2B%2BCh39Xhn-g@mail.gmail.com> <4DD00522.2010309@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, May 15, 2011, Andriy Gapon <avg@freebsd.org> wrote: > on 15/05/2011 19:19 Matthew Fleming said the following: >> On Sunday, May 15, 2011, Andriy Gapon <avg@freebsd.org> wrote: >>> on 15/05/2011 18:07 Ed Schouten said the following: >>>> Hey Andriy, >>>> >>>> * Andriy Gapon <avg@FreeBSD.org>, 20110515 16:32: >>>>> - =A0 =A0if (IS_PANIC_THREAD()) >>>>> + =A0 =A0if (THREAD_PANICED()) >>>> >>>> Shouldn't this be called THREAD_PANICKED(), with the k, instead? >>>> >>> >>> Yes, it should be. =A0Thank you. >> >> Shouldn't it be TD_IS_PANIC[K]ED to match many of the other checks >> like TD_IS_IDLETHREAD? =A0Or perhaps to avoid a spelling change, >> TD_IS_INPANIC? > > I like both of your proposals. =A0Where have you been before? :) > Ok, let's now settle on one best name and I will do another rename, that'= s easy > to do. Maybe I should start reading commits to private branches more often. :-) Cheers, matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTinHC=TP9cbhev9y33ngJrW18XBFeQ>