Date: Fri, 25 Feb 2005 07:56:14 GMT From: Joe Marcus Clarke <marcus@FreeBSD.org> To: josemi@freebsd.jazztel.es, marcus@FreeBSD.org, gnome@FreeBSD.org Subject: Re: ports/75816: [PATCH] www/firefox: new mozilla.sh and package script Message-ID: <200502250756.j1P7uEn0023933@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
Synopsis: [PATCH] www/firefox: new mozilla.sh and package script State-Changed-From-To: open->closed State-Changed-By: marcus State-Changed-When: Fri Feb 25 07:52:11 GMT 2005 State-Changed-Why: I've committed some of this. What I didn't commit was the PIS work. While the framework might be there to embed RC scripts into Mozilla and Firefox, I don't think this is the right place to add sound server support. I don't want to get bogged down in a lot of local scripts that make these ports unsupportable, or in violation of our license agreement with Mozilla. As for your pkg-[de]install work, I didn't see a real advantage of moving some of these things out into scripts. Plus, it looks like your pkg-deinstall would nuke all of browser_plugins. The rest of patches looked okay, and were merged. In the future, please do all diffs frome one level above the directory in question. For example: diff -ruN firefox.orig firefox This makes patching much easier. Also, please don't submit diffs against CVS versions. If a new version hasn't been released, either wait, or submit the diff against the current version in the ports tree. Thanks. http://www.freebsd.org/cgi/query-pr.cgi?pr=75816
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502250756.j1P7uEn0023933>