Date: Fri, 25 Apr 2003 16:29:32 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: Darren Reed <darrenr@reed.wattle.id.au> Subject: Re: misc/44148: installworld in 4.7-STABLE does not install IPFilter related header files Message-ID: <20030425132932.GA83386@sunbay.com> In-Reply-To: <20030425221643.X38215@gamplex.bde.org> References: <20030424192427.GA71112@sunbay.com> <200304250554.PAA03475@avalon.reed.wattle.id.au> <20030425062247.GE32731@sunbay.com> <20030425221643.X38215@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 25, 2003 at 10:43:22PM +1000, Bruce Evans wrote: > On Fri, 25 Apr 2003, Ruslan Ermilov wrote: >=20 > > On Fri, Apr 25, 2003 at 03:54:32PM +1000, Darren Reed wrote: > > > In some email I received from Ruslan Ermilov, sie wrote: > > > > > > Checking application/pgp-signature: FAILURE > > > -- Start of PGP signed section. > > > > On Fri, Apr 25, 2003 at 04:18:45AM +1000, Darren Reed wrote: > > > > > In some email I received from Ruslan Ermilov, sie wrote: > > > > > > In the SHARED=3Dsymlinks case, /usr/include/netinet is > > > > > > the symlink to /usr/src/sys/netinet. Hope this now > > > > > > makes more sense. > > > > > > > > > > Is there any reason to not create a real /usr/include/netinet > > > > > and then populate _that_ directory with symbolic links to each > > > > > of the files, individually ? This should preserve the semantics > > > > > of what "symlinks" is about. >=20 > Much as I dislike symlink farms, I think this would work OK (the same > as symlinks from individual headers in the top level of /usr/include to > various places in the src tree). >=20 > > > > We could create /usr/include/contrib/ipfilter/netinet, and > > > > that will be consistent with kern.pre.mk. Those that need > > > > it would just add -I/usr/include/contrib/ipfilter. How is > > > > this? >=20 > Doesn't seem any better. >=20 My worries are about the case when someone deletes or adds an include file. If we keep symlinks on a per-directory level, there's no problem. But if we switch to per-header symlinks, each time the new header is added, or old header is removed, you'll have to re-run "make install" in src/include/. Other than that, I'd like to keep the consistency in how the kernel build does this, and how this does the userland. Currently, kern.pre.mk has -I$S/contrib/ipfilter, and if we add the -I/usr/include/contrib/ipfilter, this would work as well. So, I'd like to either do this on a directory level, or kill the SHARED=3Dsymlinks concept. Please let me know what do you think before I go for implementing one or another. Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+qTg8Ukv4P6juNwoRArkIAJ9rApR8F+rWnac4985df0FyZA0FuwCfTJAd ZnaK5/nYN2wdRVEV362nAEw= =M6FS -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030425132932.GA83386>