Date: Thu, 7 Mar 2013 12:07:56 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r246856 - head/etc Message-ID: <20130307080756.GE48089@FreeBSD.org> In-Reply-To: <51378E2E.4090709@FreeBSD.org> References: <201302152258.r1FMwiQp033077@svn.freebsd.org> <20130306150133.GB48089@FreeBSD.org> <51378E2E.4090709@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jung-uk, On Wed, Mar 06, 2013 at 01:42:54PM -0500, Jung-uk Kim wrote: J> You know, I disagreed with the above change because this type of J> quirks can be easily handled by the driver. IMHO, /etc/rc.resume is J> the last place to put it. When I committed r233580 to fix resuming J> psm(4) and MFC'd it to stable/9 (r234713), we had an agreement to back J> it out if we hear no user complaints for enough time *without* merging J> your /etc/rc.resume changes. At least, that's what I remember. In J> fact, you never MFC'd your changes. So, I thought the agreement is J> still valid and it is safe to back out. I am sorry for not asking J> your confirmation, though. J> J> Now, please consider fixing psm. If you can't find a generic J> solution, it is okay to add your model-specific quirk in J> sys/dev/atkbdc/psm.c like this: J> J> http://svnweb.freebsd.org/base/head/sys/dev/atkbdc/psm.c?annotate=233580#l1441 J> J> Also, please mention it in the manual page, i.e., the CAVEATS section of J> psm(4). On my laptop the psm(4) is a generic mouse: psm0: <PS/2 Mouse> irq 12 on atkbdc0 psm0: [GIANT-LOCKED] psm0: model Generic PS/2 mouse, device ID 0 Do you suggest to add PSM_CONFIG_INITAFTERSUSPEND flag for all generic mice? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130307080756.GE48089>