Date: Thu, 29 May 1997 19:03:01 +1000 From: Bruce Evans <bde@zeta.org.au> To: cvs-all@freebsd.org, cvs-committers@freebsd.org, cvs-sys@freebsd.org, peter@freebsd.org Subject: Re: cvs commit: src/sys/sys systm.h Message-ID: <199705290903.TAA03442@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified files: > sys/sys systm.h > Log: > forward declare struct timeval so that pcibus.c doesn't get a warning. > (it doesn't #include <sys/time.h> since it doesn't need it) Actually, it should have #included either <sys/time.h>, or #included <sys/param.h> instead of <sys/types.h>, because <sys/time.h> was a prerequisite of <sys/systm.h>. This prerequisite is obfuscated by #including <sys/time.h> in <sys/param.h> of KERNEL is defined. Most kernel sources/authors don't notice the problem because they #include <sys/param.h> without thought (#including both is a style error - see style(9)). Some kernel sources didn't #include <sys/time.h> even when they did need it. I have fixed some of these. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705290903.TAA03442>