Date: Sat, 7 Mar 1998 13:37:34 -0800 (PST) From: John Dyson <dyson@FreeBSD.ORG> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/i386/i386 pmap.c src/sys/i386/include smp.h src/sys/kern kern_exec.c vfs_bio.c vfs_cluster.c vfs_default.c vfs_subr.c vfs_syscalls.c src/sys/miscfs/specfs spec_vnops.c src/sys/nfs nfs_bio.c nfs_vnops.c src/sys/sys buf.h vnode.h ... Message-ID: <199803072137.NAA10754@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
dyson 1998/03/07 13:37:34 PST
Modified files:
sys/i386/i386 pmap.c
sys/i386/include smp.h
sys/kern kern_exec.c vfs_bio.c vfs_cluster.c
vfs_default.c vfs_subr.c vfs_syscalls.c
sys/miscfs/specfs spec_vnops.c
sys/nfs nfs_bio.c nfs_vnops.c
sys/sys buf.h vnode.h
sys/ufs/ffs ffs_inode.c ffs_vfsops.c
sys/ufs/ufs ufs_readwrite.c
sys/vm swap_pager.c vm_map.c vm_mmap.c
vm_object.c vm_object.h vm_page.c
vm_page.h vm_pageout.c vm_pager.c
vm_pager.h vnode_pager.c
Log:
This mega-commit is meant to fix numerous interrelated problems. There
has been some bitrot and incorrect assumptions in the vfs_bio code. These
problems have manifest themselves worse on NFS type filesystems, but can
still affect local filesystems under certain circumstances. Most of
the problems have involved mmap consistancy, and as a side-effect broke
the vfs.ioopt code. This code might have been committed seperately, but
almost everything is interrelated.
1) Allow (pmap_object_init_pt) prefaulting of buffer-busy pages that
are fully valid.
2) Rather than deactivating erroneously read initial (header) pages in
kern_exec, we now free them.
3) Fix the rundown of non-VMIO buffers that are in an inconsistent
(missing vp) state.
4) Fix the disassociation of pages from buffers in brelse. The previous
code had rotted and was faulty in a couple of important circumstances.
5) Remove a gratuitious buffer wakeup in vfs_vmio_release.
6) Remove a crufty and currently unused cluster mechanism for VBLK
files in vfs_bio_awrite. When the code is functional, I'll add back
a cleaner version.
7) The page busy count wakeups assocated with the buffer cache usage were
incorrectly cleaned up in a previous commit by me. Revert to the
original, correct version, but with a cleaner implementation.
8) The cluster read code now tries to keep data associated with buffers
more aggressively (without breaking the heuristics) when it is presumed
that the read data (buffers) will be soon needed.
9) Change to filesystem lockmgr locks so that they use LK_NOPAUSE. The
delay loop waiting is not useful for filesystem locks, due to the
length of the time intervals.
10) Correct and clean-up spec_getpages.
11) Implement a fully functional nfs_getpages, nfs_putpages.
12) Fix nfs_write so that modifications are coherent with the NFS data on
the server disk (at least as well as NFS seems to allow.)
13) Properly support MS_INVALIDATE on NFS.
14) Properly pass down MS_INVALIDATE to lower levels of the VM code from
vm_map_clean.
15) Better support the notion of pages being busy but valid, so that
fewer in-transit waits occur. (use p->busy more for pageouts instead
of PG_BUSY.) Since the page is fully valid, it is still usable for
reads.
16) It is possible (in error) for cached pages to be busy. Make the
page allocation code handle that case correctly. (It should probably
be a printf or panic, but I want the system to handle coding errors
robustly. I'll probably add a printf.)
17) Correct the design and usage of vm_page_sleep. It didn't handle
consistancy problems very well, so make the design a little less
lofty. After vm_page_sleep, if it ever blocked, it is still important
to relookup the page (if the object generation count changed), and
verify it's status (always.)
18) In vm_pageout.c, vm_pageout_clean had rotted, so clean that up.
19) Push the page busy for writes and VM_PROT_READ into vm_pageout_flush.
20) Fix vm_pager_put_pages and it's descendents to support an int flag
instead of a boolean, so that we can pass down the invalidate bit.
Revision Changes Path
1.188 +1 -3 src/sys/i386/i386/pmap.c
1.40 +3 -3 src/sys/i386/include/smp.h
1.80 +2 -3 src/sys/kern/kern_exec.c
1.154 +71 -108 src/sys/kern/vfs_bio.c
1.56 +6 -12 src/sys/kern/vfs_cluster.c
1.13 +2 -2 src/sys/kern/vfs_default.c
1.137 +3 -3 src/sys/kern/vfs_subr.c
1.94 +4 -4 src/sys/kern/vfs_syscalls.c
1.58 +55 -31 src/sys/miscfs/specfs/spec_vnops.c
1.52 +145 -22 src/sys/nfs/nfs_bio.c
1.80 +5 -1 src/sys/nfs/nfs_vnops.c
1.46 +2 -1 src/sys/sys/buf.h
1.67 +2 -1 src/sys/sys/vnode.h
1.35 +3 -3 src/sys/ufs/ffs/ffs_inode.c
1.75 +4 -6 src/sys/ufs/ffs/ffs_vfsops.c
1.44 +96 -42 src/sys/ufs/ufs/ufs_readwrite.c
1.92 +3 -7 src/sys/vm/swap_pager.c
1.118 +6 -3 src/sys/vm/vm_map.c
1.74 +1 -8 src/sys/vm/vm_mmap.c
1.116 +13 -15 src/sys/vm/vm_object.c
1.47 +4 -1 src/sys/vm/vm_object.h
1.95 +41 -14 src/sys/vm/vm_page.c
1.38 +13 -3 src/sys/vm/vm_page.h
1.118 +19 -25 src/sys/vm/vm_pageout.c
1.36 +4 -4 src/sys/vm/vm_pager.c
1.16 +5 -2 src/sys/vm/vm_pager.h
1.89 +32 -28 src/sys/vm/vnode_pager.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199803072137.NAA10754>