Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Jun 2014 17:52:44 +0000
From:      Steve Wills <swills@freebsd.org>
To:        marino@freebsd.org
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Oliver Lehmann <oliver@freebsd.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r357767 - head/net/cyphesis
Message-ID:  <20140614175243.GD67971@mouf.net>
In-Reply-To: <539C8682.3030603@marino.st>
References:  <201406141111.s5EBBCgV016094@svn.freebsd.org> <539C8682.3030603@marino.st>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 14, 2014 at 07:29:38PM +0200, John Marino wrote:
> On 6/14/2014 13:11, Oliver Lehmann wrote:
> > Author: oliver
> > Date: Sat Jun 14 11:11:11 2014
> > New Revision: 357767
> > URL: http://svnweb.freebsd.org/changeset/ports/357767
> > QAT: https://qat.redports.org/buildarchive/r357767/
> > 
> > Log:
> >   mark as BROKEN (Does not compile with clang)
> > 
> 
> 
> But FreeBSD 8 and 9 are still supported, and it builds on those:
> http://portsmon.freebsd.org/portoverview.py?category=net&portname=cyphesis
> 
> So marking this unconditionally broken breaks it on those platforms, and
> DragonFly too.
> 
> It seems to me the action to take is:
> 1) fix it so builds regardless of compiler
> 2) nothing.  (F8, F9, + DF is better than broken everywhere.

Wouldn't the right thing be to mark it broken on FreeBSD 8 and 9 only, via
conditionals?

Steve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140614175243.GD67971>