Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Jul 2015 01:34:18 +0300
From:      Boris Samorodov <bsam@passap.ru>
To:        Alexander Leidinger <Alexander@Leidinger.net>,  Mathieu Arnold <mat@FreeBSD.org>
Cc:        ports@freebsd.org
Subject:   Re: error message from Freshports after commit?
Message-ID:  <55B5606A.6070408@passap.ru>
In-Reply-To: <20150726223123.00000f0d@Leidinger.net>
References:  <20150726152029.Horde.5fJLWJHfi3zZcyZl2BNIRA8@webmail.leidinger.net> <C613F5DA174FA175BD4AA8CF@atuin.in.mat.cc> <20150726223123.00000f0d@Leidinger.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Alexander!

26.07.2015 23:31, Alexander Leidinger пишет:
> On Sun, 26 Jul 2015 15:29:25 +0200
> Mathieu Arnold <mat@FreeBSD.org> wrote:
> 
>> +--On 26 juillet 2015 15:20:29 +0200 Alexander Leidinger
>> <Alexander@leidinger.net> wrote:
>> | 
>> | Hi,
>> | 
>> | after committing the 64bit parts of the linux base ports, I got a
>> mail | parts of the commit. Those parts work just fine on my
>> (current) system. | What's wrong?
>>
>> You're running 10.x I assume, install fmake, or try on a 9.x or 8.x
>> system.
> 
> It's -current.
> 
> I installed fmake now and it complains about
> # fmake -V PORTNAME
> "/usr/share/mk/sys.mk", line 36: Unknown directive
> "/usr/share/mk/sys.mk", line 364: Unknown directive
> Unknown modifier 'U'
> 
> As I didn't change that file, that seems to be a dead end.
> 
> 
> The fmake man-page says:
> ---snip---
>      An expression may also be a numeric or string comparison: in this
> case, the left-hand side must be a variable expansion, whereas the
> right-hand side can be a constant or a variable expansion.  Variable
> expansion is performed on both sides, after which the resulting values
> are compared. A value is interpreted as hexadecimal if it is preceded
> by 0x, otherwise it is decimal; octal numbers are not supported.
> ---snip...
> 
> Now... is
> ---snip---
> testtarget:
> .if "${QUOTED_VAR}" == "test"
> 	echo works
> .endif
> ---snip---

% make QUOTED_VAR=test
"Makefile", line 2: Malformed conditional ("${QUOTED_VAR}" == "test")
"Makefile", line 4: if-less endif
make: fatal errors encountered -- cannot continue

> a variable expansion as of above, or do I need to remove the quotes
> like below
> ---snip---
> testtarget:
> .if ${QUOTED_VAR} == "test"
> 	echo works
> .endif
> ---snip---

% make QUOTED_VAR=test
echo works
works

If QUOTED_VAR is not defined, the test fails:

% make
"Makefile", line 2: Malformed conditional (${QUOTED_VAR} == "test")
"Makefile", line 4: if-less endif
make: fatal errors encountered -- cannot continue


> Anyone out there with a 8.x or 9.x system who can test the above?

The system is:

% uname -a
FreeBSD host.wart.ru 9.3-STABLE FreeBSD 9.3-STABLE #34 r285813: Fri Jul
24 00:03:24 MSK 2015     bsam@host.wart.ru:/usr/obj/usr/src/sys/HOST  i386

-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55B5606A.6070408>