Date: Sat, 27 Jan 2001 09:18:14 +0100 From: "Steve O'Hara-Smith" <steveo@eircom.net> To: John Baldwin <jhb@FreeBSD.org> Cc: current@FreeBSD.org Subject: Re: patch for test: /etc/shells -> /usr/local/etc/shells Message-ID: <20010127091814.567fda08.steveo@eircom.net> In-Reply-To: <XFMail.010126141342.jhb@FreeBSD.org> References: <20010126220820.2fa3265a.steveo@eircom.net> <XFMail.010126141342.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 26 Jan 2001 14:13:42 -0800 (PST)
John Baldwin <jhb@FreeBSD.org> wrote:
JB> 1) All parsing of /etc/shells should move off into libutil under a
JB> suitable API.
There is one in libc/gen that would do fine. The catch is that it
is not used everywhere and some of the code that fails to use it is in contrib
and I am not too sure of the wisdom of changing it.
JB> 2) The implementation of this API should allow for multiple files that it
JB> checks. One way might be to add a '.include' keyword or something so
JB> that /etc/shells could have '.include /usr/local/etc/shells' that the
JB> admin could adjust should he/she choose to change ${LOCALBASE} to
JB> something other than /usr/local.
I did consider an include mechanism and making _PATH_SHELLS a path list.
I was leaning in the direction of an include mechanism when the (bad) idea of
changing _PATH_SHELLS to point to /usr/local which removed any need to patch
roken, adduser.pl and sendmail.
JB> This is more work than your patch, but this patch doesn't really solve
JB> the problem, it merely moves it. It also breaks for ${LOCALBASE}
JB> != /usr/local, so I don't think it should go in.
Good points, agreed.
Thoughts please on the wisdom of patching the above areas to handle
an include syntax, my worry is maintenance since most of it is contib. I don't
know if I would be introducing the first changes to them (in which cas I will
not) or just one of many (in which case I'll start coding). ?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010127091814.567fda08.steveo>