Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Jan 2012 22:00:29 GMT
From:      dfilter@FreeBSD.ORG (dfilter service)
To:        freebsd-sparc64@FreeBSD.org
Subject:   Re: sparc64/164226: commit references a PR
Message-ID:  <201201272200.q0RM0Ttq002092@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR sparc64/164226; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: sparc64/164226: commit references a PR
Date: Fri, 27 Jan 2012 21:53:14 +0000 (UTC)

 Author: marius
 Date: Fri Jan 27 21:52:59 2012
 New Revision: 230627
 URL: http://svn.freebsd.org/changeset/base/230627
 
 Log:
   Using ATA_CAM along with ATAPI DMA causes data corruption with ALI_NEW
   and CMD controllers for reasons unknown so disable it.
   
   PR:	164226
 
 Modified:
   head/sys/dev/ata/chipsets/ata-acerlabs.c
   head/sys/dev/ata/chipsets/ata-siliconimage.c
 
 Modified: head/sys/dev/ata/chipsets/ata-acerlabs.c
 ==============================================================================
 --- head/sys/dev/ata/chipsets/ata-acerlabs.c	Fri Jan 27 21:49:02 2012	(r230626)
 +++ head/sys/dev/ata/chipsets/ata-acerlabs.c	Fri Jan 27 21:52:59 2012	(r230627)
 @@ -213,6 +213,10 @@ ata_ali_ch_attach(device_t dev)
  	if (ch->dma.max_iosize > 256 * 512)
  		ch->dma.max_iosize = 256 * 512;
      }
 +#ifdef ATA_CAM
 +	if (ctlr->chip->cfg2 & ALI_NEW)
 +		ch->flags |= ATA_NO_ATAPI_DMA;
 +#endif
  
      return 0;
  }
 
 Modified: head/sys/dev/ata/chipsets/ata-siliconimage.c
 ==============================================================================
 --- head/sys/dev/ata/chipsets/ata-siliconimage.c	Fri Jan 27 21:49:02 2012	(r230626)
 +++ head/sys/dev/ata/chipsets/ata-siliconimage.c	Fri Jan 27 21:52:59 2012	(r230627)
 @@ -240,6 +240,10 @@ ata_cmd_ch_attach(device_t dev)
      if (ctlr->chip->cfg2 & SII_INTR)
  	ch->hw.status = ata_cmd_status;
  
 +#ifdef ATA_CAM
 +	ch->flags |= ATA_NO_ATAPI_DMA;
 +#endif
 +
      return 0;
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201272200.q0RM0Ttq002092>