Date: Tue, 16 Apr 2002 12:39:05 -0400 From: Mike Barcroft <mike@freebsd.org> To: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at> Cc: Maxim Sobolev <sobomax@freebsd.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: ports/emulators/wine Makefile distinfo pkg-plist Message-ID: <20020416123905.C72402@espresso.q9media.com> In-Reply-To: <Pine.BSF.4.44.0204161647060.37987-100000@naos.dbai.tuwien.ac.at>; from pfeifer@dbai.tuwien.ac.at on Tue, Apr 16, 2002 at 05:01:41PM %2B0200 References: <200204121950.g3CJo0O21945@vega.vega.com> <Pine.BSF.4.44.0204161647060.37987-100000@naos.dbai.tuwien.ac.at>
next in thread | previous in thread | raw e-mail | index | archive | help
Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at> writes: > On Fri, 12 Apr 2002, Maxim Sobolev wrote: > >> I have been the maintainer of this port since 2000/05/18. > >> And while David O'Brien (my mentor here) kindly has been and will be > >> reviewing my patches to all other parts of FreeBSD, do I really need > >> to have my changes to this port reviewed/approved by others now, after > >> having submitted/reviewed/approved more than two dozen changes as > >> maintainer of this port??? > > Yes, you need. This is normal part of your "mentored" period. You > > mentor should have told you that. > > In that case, I am sorry about not getting approval first. David did not > feel it was needed for Wine commits. Maybe that is because he knows my > abilities already, and forgot that others here do not. > > (David has closely followed my first seven commits before the Wine port > update, and he knows I've been using CVS on a daily basis for years. > Also, the the Committer's Guide, which I had read twice, does not seem > to mandate this.) I'll say it again. :) This is a mentor/mentee issue. Maxim, or myself for that matter, have no business in this area. If your mentor approves of unreviewed commits in an area you've been maintaining for years, that's fine. You should probably have an "Approved by:" line even for implicit approval though. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020416123905.C72402>