Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Sep 2001 18:11:24 -0500
From:      Chris Costello <chris@calldei.com>
To:        Maxim Sobolev <sobomax@FreeBSD.ORG>
Cc:        Poul-Henning Kamp <phk@critter.freebsd.dk>, Brent Verner <brent@rcfile.org>, current@FreeBSD.ORG, hackers@FreeBSD.ORG
Subject:   Re: Junior Kernel Hacker task: improve vnode->v_tag
Message-ID:  <20010907181124.B548@holly.calldei.com>
In-Reply-To: <200109041904.f84J4ZZ99036@vega.vega.com>; from sobomax@FreeBSD.ORG on Tue, Sep 04, 2001 at 10:04:35PM %2B0300
References:  <12420.999618814@critter> <200109041904.f84J4ZZ99036@vega.vega.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, September 04, 2001, Maxim Sobolev wrote:
Content-Description: ASCII C program text
> Index: coda/coda.h
> ===================================================================
> RCS file: /home/ncvs/src/sys/coda/coda.h,v
> retrieving revision 1.9
> diff -d -u -r1.9 coda.h
> --- coda/coda.h	1999/12/29 04:54:30	1.9
> +++ coda/coda.h	2001/09/04 18:46:42
> @@ -41,7 +41,7 @@
>  #ifndef _CODA_HEADER_
>  #define _CODA_HEADER_
>  
> -
> +#define VT_CODA "VT_CODA"
...

   I don't think that the point of this is to use a string like
that, but rather a descriptive string, i.e.

#define	VT_FDESCFS	"file-descriptor file system"
#define	VT_NFS		"network file system"

   But is it necessary that you really use those defines?  The
idea is not to use them globally.  Perhaps getnewvnode() should
get the string from `mp->mnt_stat.f_mntfromname', instead...

-- 
+-------------------+-------------------------------------------+
| Chris Costello    | As far as we know, our computer has never |
| chris@calldei.com | had an undetected error.        - Weisert |
+-------------------+-------------------------------------------+

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010907181124.B548>