Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 03 Mar 2013 10:34:36 -0500
From:      Pedro Giffuni <pfg@FreeBSD.org>
To:        Jilles Tjoelker <jilles@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r247713 - head/lib/libedit
Message-ID:  <51336D8C.9000105@FreeBSD.org>
In-Reply-To: <201303031442.r23EgGQ7068252@svn.freebsd.org>
References:  <201303031442.r23EgGQ7068252@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 03/03/2013 09:42, Jilles Tjoelker wrote:
> Author: jilles
> Date: Sun Mar  3 14:42:15 2013
> New Revision: 247713
> URL: http://svnweb.freebsd.org/changeset/base/247713
>
> Log:
>    libedit: Revert r247683 to fix buildworld.
>    
>    I think r247683 is wrong because libedit.so actually uses symbols from
>    libcurses.so. Since it breaks the build, revert it now.
>
> Modified:
>    head/lib/libedit/Makefile
>
> Modified: head/lib/libedit/Makefile
> ==============================================================================
> --- head/lib/libedit/Makefile	Sun Mar  3 14:05:03 2013	(r247712)
> +++ head/lib/libedit/Makefile	Sun Mar  3 14:42:15 2013	(r247713)
> @@ -11,6 +11,7 @@ OSRCS=	chared.c common.c el.c emacs.c fc
>   	parse.c prompt.c read.c refresh.c search.c sig.c term.c tty.c vi.c
>   
>   DPADD=	${LIBNCURSES}
> +LDADD=	-lncurses
>   
>   MAN=	editline.3 editrc.5
>   
>

Thank you for reverting. My router broke this morning or I would've
done it first.

I have no idea why NetBSD survives without linking ncurses here but
next time I will test this further before trusting the package author.

Pedro.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51336D8C.9000105>