Date: Tue, 17 Dec 2002 22:42:05 -0500 From: "Brian F. Feldman" <green@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: "M. Warner Losh" <imp@bsdimp.com>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot2.c Message-ID: <200212180342.gBI3g5H8015208@green.bikeshed.org> In-Reply-To: Your message of "Wed, 18 Dec 2002 14:02:43 %2B1100." <20021218130326.G23022-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans <bde@zeta.org.au> wrote: > On Tue, 17 Dec 2002, Brian F. Feldman wrote: > > > "M. Warner Losh" <imp@bsdimp.com> wrote: > > > In message: <200212172213.gBHMD7wd013565@green.bikeshed.org> > > > "Brian F. Feldman" <green@FreeBSD.org> writes: > > > : Warner Losh <imp@FreeBSD.org> wrote: > > > : > imp 2002/12/17 14:00:06 PST > > > : > > > > : > Modified files: > > > : > sys/boot/i386/boot2 boot2.c > > > : > Log: > > > : > Reduce diffs with Peter's expanded diffs: > > > : > 1) Put back the keyboard printing printf, at the cost of 58 bytes. > > > : > 2) Minor tweak to getstr at no apparent cost. > > > : > > > : Hmm, after all this work on boot2, I remain confused as to why noone else > > > : working on the boot blocks seems to have any trouble reinstalling them > > > : to test. Am I really the only one that had to fix disklabel.c so that it > > > : would install boot blocks instead of just dying on a post-GEOM system? > > > : It seems strange that it's only a few people here that would be having that > > > : issue :) > > > > > > I had to hack disklabel.c in unnatural ways to install to test. > > > > Is this better? > > This seems to be mainly to work around missing support for DIOCWLABEL in > GEOM. I don't use GEOM, so I have no problems with disk labels. To put this in context, this is because with GEOM the disklabels now explicitly contain (in the new format) the offset in terms of the slice, rather than starting at 0. The disklabel -r can't possibly work because disklabel(8) won't read the correct (old-style, 0 offset) label off the device, which won't match the adjusted format that disklabel without -r gets from GEOM. So, when disklabel(8) thinks that the labels are full of errors because it thinks offsets are always supposed to start at 0 in the disklabel, it generates lots of warnings. Writing over the label on the disk won't work with GEOM, and just calling DIOCWDINFO won't work when you disklabel -r (also disklabel -B's implicit -r) because the offsets would be incorrect. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200212180342.gBI3g5H8015208>