Date: Sun, 16 Aug 2009 13:28:49 GMT From: Edward Tomasz Napierala <trasz@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 167403 for review Message-ID: <200908161328.n7GDSn9J066763@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=167403 Change 167403 by trasz@trasz_anger on 2009/08/16 13:27:56 More KASSERTs. Affected files ... .. //depot/projects/soc2009/trasz_limits/sys/kern/kern_loginclass.c#11 edit .. //depot/projects/soc2009/trasz_limits/sys/kern/kern_resource.c#23 edit Differences ... ==== //depot/projects/soc2009/trasz_limits/sys/kern/kern_loginclass.c#11 (text+ko) ==== @@ -88,11 +88,10 @@ mtx_lock(&loginclasses_lock); if (refcount_release(&lc->lc_refcount)) { for (i = 0; i < HRL_RESOURCE_MAX; i++) { - if (lc->lc_usage.hu_resources[i] != 0) - printf("loginclass_release: freeing " - "loginclass \"%s\", resource %d = %lld\n", - lc->lc_name, i, - lc->lc_usage.hu_resources[i]); + KASSERT(lc->lc_usage.hu_resources[i] == 0, + ("loginclass_release: freeing " + "loginclass \"%s\", resource %d = %lld\n", + lc->lc_name, i, lc->lc_usage.hu_resources[i])); } LIST_REMOVE(lc, lc_next); mtx_unlock(&loginclasses_lock); ==== //depot/projects/soc2009/trasz_limits/sys/kern/kern_resource.c#23 (text+ko) ==== @@ -1397,10 +1397,10 @@ uip->ui_uid, (unsigned long long)uip->ui_vmsize); mtx_destroy(&uip->ui_vmsize_mtx); for (i = 0; i < HRL_RESOURCE_MAX; i++) { - if (uip->ui_usage.hu_resources[i] != 0) - printf("uifree: freeing uidinfo: uid = %d, " - "resource %d = %lld \n", uip->ui_uid, i, - uip->ui_usage.hu_resources[i]); + KASSERT(uip->ui_usage.hu_resources[i] == 0, + ("uifree: freeing uidinfo: uid = %d, " + "resource %d = %lld \n", uip->ui_uid, i, + uip->ui_usage.hu_resources[i])); } free(uip, M_UIDINFO); return; @@ -1567,10 +1567,10 @@ LIST_REMOVE(gip, gi_hash); rw_wunlock(&gihashtbl_lock); for (i = 0; i < HRL_RESOURCE_MAX; i++) { - if (gip->gi_usage.hu_resources[i] != 0) - printf("gifree: freeing gidinfo: gid = %d, " - "resource %d = %lld \n", gip->gi_gid, i, - gip->gi_usage.hu_resources[i]); + KASSERT(gip->gi_usage.hu_resources[i] == 0, + ("gifree: freeing gidinfo: gid = %d, " + "resource %d = %lld \n", gip->gi_gid, i, + gip->gi_usage.hu_resources[i])); } free(gip, M_GIDINFO); return;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908161328.n7GDSn9J066763>