Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Feb 2013 10:16:58 +0000 (UTC)
From:      Sergey Kandaurov <pluknet@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r246757 - stable/9/sys/kern
Message-ID:  <201302131016.r1DAGxRJ023620@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pluknet
Date: Wed Feb 13 10:16:58 2013
New Revision: 246757
URL: http://svnweb.freebsd.org/changeset/base/246757

Log:
  MFC r246412:
    Prezero the acl structure which is to be copied to usermode, to avoid
    leakage of the previous content of padding and unitialized fields.

Modified:
  stable/9/sys/kern/vfs_acl.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/kern/vfs_acl.c
==============================================================================
--- stable/9/sys/kern/vfs_acl.c	Wed Feb 13 09:20:55 2013	(r246756)
+++ stable/9/sys/kern/vfs_acl.c	Wed Feb 13 10:16:58 2013	(r246757)
@@ -247,7 +247,7 @@ vacl_get_acl(struct thread *td, struct v
 	struct acl *inkernelacl;
 	int error;
 
-	inkernelacl = acl_alloc(M_WAITOK);
+	inkernelacl = acl_alloc(M_WAITOK | M_ZERO);
 	vn_lock(vp, LK_EXCLUSIVE | LK_RETRY);
 #ifdef MAC
 	error = mac_vnode_check_getacl(td->td_ucred, vp, type);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302131016.r1DAGxRJ023620>