Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Jun 2014 17:44:49 +0200
From:      Koop Mast <kwm@FreeBSD.org>
To:        Dmitry Marakasov <amdmi3@amdmi3.ru>
Cc:        "Alex V. Petrov" <alexvpetrov@gmail.com>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r358277 - head/graphics/ImageMagick
Message-ID:  <1403192689.29145.2.camel@crashalot.rainbow-runner.nl>
In-Reply-To: <20140619152645.GE62706@hades.panopticon>
References:  <201406181434.s5IEYugU088980@svn.freebsd.org> <20140619152645.GE62706@hades.panopticon>

next in thread | previous in thread | raw e-mail | index | archive | help
On do, 2014-06-19 at 19:26 +0400, Dmitry Marakasov wrote:
> * Koop Mast (kwm@FreeBSD.org) wrote:
> 
> > Author: kwm
> > Date: Wed Jun 18 14:34:55 2014
> > New Revision: 358277
> > URL: http://svnweb.freebsd.org/changeset/ports/358277
> > QAT: https://qat.redports.org/buildarchive/r358277/
> > 
> > Log:
> >   IM uses .la files to find the plugins. Add :keepla back to USES=libtool,
> >   and a note that it is needed.
> 
> Removing :keepla was illegal due to another reason: not all ports that
> depend on ImageMagick were converted to USES=libtool yet. Those not
> converted will still have references to ImageMagick's .la's in their
> .la files, which will lead to certain build failures.

Yeah that's a good point but .. since the library name changed the .la
files where invalid anyway and all users of the library needed to be
recompiled anyway.

> Regarding loading plugins, it's related to libltdl. The library can
> load plain .so files as well, but ".la" paths is passed to it
> explicitely so it won't. This probably can be fixed by changing 3
> occurances of ".la" in magick/module.c to .so (or removing extensions
> and using lt_dlopenext instead of lt_dlopen, see [1])
> 
> http://www.redhat.com/archives/fedora-packaging/2006-October/msg00068.html
> 
> Would be nice for someone to experiment on this so we still could
> drop .la's from ImageMagick in future.
> 

This is a very nice tip, I will take this into consideration and see if
upstream is open for changing some magic :)

Thanks!

-Koop




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1403192689.29145.2.camel>