Date: Tue, 02 Oct 2007 16:50:37 -0700 (PDT) From: Cy Schubert <cy@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/116849: dump(8) fails to dump UFS filesystems when nullfs filesyste present Message-ID: <200710022350.l92Nobww030741@cwsys.cwsent.com> Resent-Message-ID: <200710030100.l93103a7014593@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 116849 >Category: bin >Synopsis: dump(8) fails to dump UFS filesystems when nullfs filesyste present >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 03 01:00:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Cy Schubert >Release: FreeBSD-2.0 >Organization: FreeBSD >Environment: System: FreeBSD bob 6.2-STABLE FreeBSD 6.2-STABLE #3: Thu Sep 27 16:38:11 PDT 2007 root@cwsys:/export/obj/opt/src/cvs-stable6/src/sys/KOMQUATS i386 >Description: Example fstab: /dev/ad3s1g /dsk01 ufs rw 1 2 [...] /dsk01 /stable5/dsk01 nullfs rw,noauto 0 0 # dump 0f /dev/null /dsk01 dump: unknown filesystem /dsk01 # >How-To-Repeat: See above >Fix: --- sbin/dump/optr.c.orig 2005-02-15 22:48:35.000000000 -0800 +++ sbin/dump/optr.c 2007-10-02 16:33:26.000000000 -0700 @@ -315,9 +315,10 @@ return; } while ((fs = getfsent()) != NULL) { - if (strcmp(fs->fs_type, FSTAB_RW) && + if ((strcmp(fs->fs_type, FSTAB_RW) && strcmp(fs->fs_type, FSTAB_RO) && - strcmp(fs->fs_type, FSTAB_RQ)) + strcmp(fs->fs_type, FSTAB_RQ)) || + strcmp(fs->fs_vfstype, "ufs")) continue; fs = allocfsent(fs); if ((pf = (struct pfstab *)malloc(sizeof (*pf))) == NULL) >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710022350.l92Nobww030741>