Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Feb 2010 15:56:08 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Ulrich =?iso-8859-1?q?Sp=F6rlein?= <uqs@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r203926 - in head/games/fortune: fortune strfile unstr
Message-ID:  <201002171556.08395.jhb@freebsd.org>
In-Reply-To: <20100217185133.GL57731@acme.spoerlein.net>
References:  <201002151510.o1FFAMgv035651@svn.freebsd.org> <201002171143.57885.jhb@freebsd.org> <20100217185133.GL57731@acme.spoerlein.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 17 February 2010 1:51:33 pm Ulrich Sp=F6rlein wrote:
> On Wed, 17.02.2010 at 11:43:57 -0500, John Baldwin wrote:
> > On Monday 15 February 2010 10:10:22 am Ulrich Spoerlein wrote:
> > > Author: uqs
> > > Date: Mon Feb 15 15:10:21 2010
> > > New Revision: 203926
> > > URL: http://svn.freebsd.org/changeset/base/203926
> > >=20
> > > Log:
> > >   fortune(6) switch to 3-clause BSDL; style(9)
> > >  =20
> > >   This reduces the diff to other *BSD and makes it possible to actual=
ly
> > >   see the code differences.
> > >  =20
> > >   Approved by:	ed (Co-mentor)
> >=20
> > There appear to be a lot of unrelated changes to at least fortune.c in =
this=20
> > commit.
>=20
> Hi John,
>=20
> care to elaborate? The commit log says that style(9) has been applied
> and it is a diff reduction commit in general.
>=20
> That said, the only object code altering change is the replacing of
> exit(0) with return(0) at the end of main(). There's nothing definitive
> in style(9) about that ...

Oh, I missed the 'style(9)' bit.  A full sentence and even separate line
items such as:

=2D Switch to a 3-clause BSD license.
=2D Various style(9) fixes.

might help to reduce any confusion in the future.

=2D-=20
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201002171556.08395.jhb>