Date: Tue, 23 Aug 2005 11:33:10 -0700 From: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: "Evgueni V. Gavrilov" <aquatique@rusunix.org>, freebsd-current@freebsd.org, glebius@freebsd.org, freebsd-net@freebsd.org Subject: Re: [Fwd: assigning an address to ng_fec(4) iface causes panic] Message-ID: <bb4a86c705082311337770151f@mail.gmail.com> In-Reply-To: <20050823173622.GB6926@odin.ac.hmc.edu> References: <430B57A7.1050402@savvis.net> <bb4a86c70508231009131c50f2@mail.gmail.com> <20050823173622.GB6926@odin.ac.hmc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_1088_19999326.1124821990561
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On 8/23/05, Brooks Davis <brooks@one-eyed-alien.net> wrote:
> On Tue, Aug 23, 2005 at 10:09:06AM -0700, Maksim Yevmenkin wrote:
> > Hello,
> >
> > please try the attached patch.
> >
> > > >Description:
> > > assigning an address to ng_fec(4) iface causes panic
> > > during dumping to dumpdev another panic occurs preventing to =
identify the source of the first panic and having the crash dump
> > >
> > > ng_iface creation sequence:
> > > mkpeer fec dummy fec
> > > msg fec0: add_iface "em0"
> > > msg fec0: add_iface "em1"
> > > msg fec0: set_mode_mac
> > >
>=20
> > --- ng_fec.c.orig Mon Aug 22 11:42:51 2005
> > +++ ng_fec.c Tue Aug 23 10:05:23 2005
> > @@ -544,8 +544,8 @@
> > struct ifnet *ifp, *bifp;
> > struct ng_fec_portlist *p;
> >
> > - ifp =3D arg;
> > - priv =3D ifp->if_softc;
> > + priv =3D arg;
> > + ifp =3D priv->ifp;
> > b =3D &priv->fec_bundle;
> >
> > if (b->fec_ifcnt =3D=3D 1 || b->fec_ifcnt =3D=3D 3) {
>=20
> This isn't quite sufficent. You also should change the ng_fec_init(ifp)
> call on line 718 to ng_fec_init(ifp->if_softc). If that work's I'll
> commit it.
oops... i missed this. thanks for catching this! i do not have
hardware to test it :) i have attached updated path. if anyone could
please test it and confirm that it works then feel free to commit it
(or let me know and i can commit it myself :)
> I've got to say this calling convention is really stupid. I'm
> really tempted to change ifp->if_init() to take a struct ifnet * even
> though it means an API change and a tree sweep.
sounds good to me.
thanks,
max
------=_Part_1088_19999326.1124821990561
Content-Type: text/plain; name="ng_fec.c.diff.txt"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="ng_fec.c.diff.txt"
LS0tIG5nX2ZlYy5jLm9yaWcJTW9uIEF1ZyAyMiAxMTo0Mjo1MSAyMDA1CisrKyBuZ19mZWMuYwlU
dWUgQXVnIDIzIDExOjI4OjM2IDIwMDUKQEAgLTU0NCw4ICs1NDQsOCBAQAogCXN0cnVjdCBpZm5l
dAkJKmlmcCwgKmJpZnA7CiAJc3RydWN0IG5nX2ZlY19wb3J0bGlzdAkqcDsKIAotCWlmcCA9IGFy
ZzsKLQlwcml2ID0gaWZwLT5pZl9zb2Z0YzsKKwlwcml2ID0gYXJnOworCWlmcCA9IHByaXYtPmlm
cDsKIAliID0gJnByaXYtPmZlY19idW5kbGU7CiAKIAlpZiAoYi0+ZmVjX2lmY250ID09IDEgfHwg
Yi0+ZmVjX2lmY250ID09IDMpIHsKQEAgLTcxNSw3ICs3MTUsNyBAQAogCQkJCX0KIAkJCQlpZnAt
PmlmX2Rydl9mbGFncyAmPSB+KElGRl9EUlZfT0FDVElWRSk7CiAJCQkJaWZwLT5pZl9kcnZfZmxh
Z3MgfD0gSUZGX0RSVl9SVU5OSU5HOwotCQkJCW5nX2ZlY19pbml0KGlmcCk7CisJCQkJbmdfZmVj
X2luaXQocHJpdik7CiAJCQl9CiAJCQkvKgogCQkJICogQnViYmxlIGRvd24gY2hhbmdlcyBpbiBw
cm9taXNjIG1vZGUgdG8K
------=_Part_1088_19999326.1124821990561--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c705082311337770151f>